Display userinfo #484

JohannesDoberer · 2019-04-15T08:51:44Z

No description provided.

…isplay-user-name-or-email

core/examples/luigi-sample-angular/src/luigi-config/extended/auth.js

docs/authorization-configuration.md

maxmarkus

Please check my comments.

…er/luigi into display-user-name-or-email

bszwarc

Added some comments

bszwarc · 2019-04-17T11:56:00Z

docs/authorization-configuration.md

@@ -39,6 +40,7 @@ auth: {
 - **automaticSilentRenew** enables the automatic silent renewal of the token if it is supported by the server. The default value is `false`. For this mechanism to work, the browser must have third-party cookies support enabled.
 - **accessTokenExpiringNotificationTime** is the number of seconds before an access token is to expire and triggers silent token refresh. The default value is 60.
 - **thirdPartyCookiesScriptLocation** is the URL to the page containing third-party cookies support check. For details, see [Third-party cookies and silent token refresh section](#Third-party-cookies-and-silent-token-refresh).
+- **userInfoFn** provides a function to get user information. It returns a promise of an user info object which contains user name and/or email to display it in the profile dropdown.


Suggested change

- **userInfoFn** provides a function to get user information. It returns a promise of an user info object which contains user name and/or email to display it in the profile dropdown.

- **userInfoFn** provides a function to get user information. It returns a promise of a user info object which contains user name and/or email to display in the profile dropdown.

bszwarc · 2019-04-17T11:56:25Z

docs/authorization-configuration.md

@@ -74,6 +77,39 @@ auth: {
 - **response_type** defaults to the **id_token**. Any other parameter that is added to oAuthData is also added to the authorization payload.
 - **nonceFn** provides a function that returns a string in order to override the default **nonce**.
 - **logoutFn** provides the function to override the **logoutUrl** functionality for a custom logout. It needs to execute the **logoutCallback()** function after logout.
+- **userInfoFn** provides a function to get user information. It returns a promise of an user info object which contains user name and/or email to display it in the profile dropdown.


Suggested change

- **userInfoFn** provides a function to get user information. It returns a promise of an user info object which contains user name and/or email to display it in the profile dropdown.

- **userInfoFn** provides a function to get user information. It returns a promise of a user info object which contains user name and/or email to display in the profile dropdown.

bszwarc · 2019-04-17T11:58:35Z

docs/authorization-configuration.md

+
+    userInfo(){
+        // logic to get some user information
+        // returns a promise of an userinfo object which contains user name and/or email to display it in the profile dropdown


Suggested change

// returns a promise of an userinfo object which contains user name and/or email to display it in the profile dropdown

// returns a promise of a userinfo object which contains user name and/or email to display in the profile dropdown menu

bszwarc · 2019-04-17T12:01:30Z

docs/authorization-configuration.md

+- **userInfoFn** provides a function to get user information. It returns a promise of an user info object which contains user name and/or email to display it in the profile dropdown.
+
+
+### Custom Authentification Provider


I'm wondering, should it be authentification or authentication? I was researching similar providers and it was authentication 🤔 but I might be wrong :) However, it is used to authenticate the user right?

You are totally right :)

bszwarc · 2019-04-17T12:02:10Z

docs/authorization-configuration.md

+
+### Custom Authentification Provider
+
+If you are using any authentification provider you also have the possibility to implement some functions that luigi can deal with.


Suggested change

If you are using any authentification provider you also have the possibility to implement some functions that luigi can deal with.

If you are using any authentication provider you can also implement some other functions for Luigi to use.

bszwarc · 2019-04-17T12:02:24Z

docs/authorization-configuration.md

+
+    login(){
+        // logic to handle the login mechanism
+        // returns a promise which contains a error message if something went wrong


Suggested change

// returns a promise which contains a error message if something went wrong

// returns a promise which contains an error message if something went wrong

bszwarc · 2019-04-17T12:34:18Z

docs/authorization-configuration.md

+
+    userInfo(){
+        // logic to get some user information
+        // returns a promise of a userinfo object which contains user name and/or email to display in the profile dropdown menu


Suggested change

// returns a promise of a userinfo object which contains user name and/or email to display in the profile dropdown menu

// returns a promise of a userinfo object which contains a user name and/or email to display in the profile dropdown menu

bszwarc · 2019-04-17T12:34:44Z

docs/authorization-configuration.md

@@ -39,6 +40,7 @@ auth: {
 - **automaticSilentRenew** enables the automatic silent renewal of the token if it is supported by the server. The default value is `false`. For this mechanism to work, the browser must have third-party cookies support enabled.
 - **accessTokenExpiringNotificationTime** is the number of seconds before an access token is to expire and triggers silent token refresh. The default value is 60.
 - **thirdPartyCookiesScriptLocation** is the URL to the page containing third-party cookies support check. For details, see [Third-party cookies and silent token refresh section](#Third-party-cookies-and-silent-token-refresh).
+- **userInfoFn** provides a function to get user information. It returns a promise of a user info object which contains user name and/or email to display in the profile dropdown.


Suggested change

- **userInfoFn** provides a function to get user information. It returns a promise of a user info object which contains user name and/or email to display in the profile dropdown.

- **userInfoFn** provides a function to get user information. It returns a promise of a **userinfo** object which contains user name and/or email to display in the profile dropdown menu.

bszwarc · 2019-04-17T12:35:27Z

docs/authorization-configuration.md

@@ -74,6 +77,39 @@ auth: {
 - **response_type** defaults to the **id_token**. Any other parameter that is added to oAuthData is also added to the authorization payload.
 - **nonceFn** provides a function that returns a string in order to override the default **nonce**.
 - **logoutFn** provides the function to override the **logoutUrl** functionality for a custom logout. It needs to execute the **logoutCallback()** function after logout.
+- **userInfoFn** provides a function to get user information. It returns a promise of a user info object which contains user name and/or email to display in the profile dropdown.


Suggested change

- **userInfoFn** provides a function to get user information. It returns a promise of a user info object which contains user name and/or email to display in the profile dropdown.

- **userInfoFn** provides a function to get user information. It returns a promise of a **userinfo** object which contains user name and/or email to display in the profile dropdown menu.

no message

45c0069

JohannesDoberer requested review from antiheld, dariadomagala-sap, hardl, jesusreal, kwiatekus, marynaKhromova, maxmarkus, parostatkiem-zz, pekura and y-kkamil as code owners April 15, 2019 08:51

maxmarkus added area/luigi enhancement New feature or request labels Apr 15, 2019

maxmarkus added this to the Sprint_Swinka_12 milestone Apr 15, 2019

JohannesDoberer added 2 commits April 15, 2019 14:35

docu

356da15

Merge branch 'master' into display-user-name-or-email

857e096

JohannesDoberer requested review from bszwarc, kazydek, klaudiagrz, mmitoraj and tomekpapiernik as code owners April 15, 2019 12:36

JohannesDoberer added 5 commits April 15, 2019 14:41

docu

f039f39

tets

59b0fd6

no message

d1fd16a

no message

0fa1386

no message

8b837f9

maxmarkus self-assigned this Apr 15, 2019

maxmarkus added 2 commits April 15, 2019 16:00

Merge remote-tracking branch 'upstream/master' into JohannesDoberer-d…

7ae6296

…isplay-user-name-or-email

some more linting fixes

f1dec69

maxmarkus reviewed Apr 15, 2019

View reviewed changes

core/examples/luigi-sample-angular/src/luigi-config/extended/auth.js Show resolved Hide resolved

maxmarkus reviewed Apr 15, 2019

View reviewed changes

docs/authorization-configuration.md Show resolved Hide resolved

maxmarkus suggested changes Apr 15, 2019

View reviewed changes

maxmarkus changed the title ~~display userinfo~~ Display userinfo Apr 15, 2019

JohannesDoberer added 7 commits April 16, 2019 13:17

review changes

a54e174

Merge branch 'display-user-name-or-email' of github.com:JohannesDober…

7dc4892

…er/luigi into display-user-name-or-email

no message

68b021c

no message

a103bcd

no message

393c12d

Merge branch 'master' into display-user-name-or-email

22a3e8e

jetzt aber

80d033c

bszwarc reviewed Apr 17, 2019

View reviewed changes

docu review

e48498b

bszwarc reviewed Apr 17, 2019

View reviewed changes

docu review part 2

2be477b

bszwarc approved these changes Apr 17, 2019

View reviewed changes

maxmarkus approved these changes Apr 17, 2019

View reviewed changes

JohannesDoberer merged commit 1eb1b51 into SAP:master Apr 17, 2019

JohannesDoberer deleted the display-user-name-or-email branch April 17, 2019 14:46

stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021

Display userinfo (SAP#484)

6cb022c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display userinfo #484

Display userinfo #484

JohannesDoberer commented Apr 15, 2019

maxmarkus left a comment

bszwarc left a comment

bszwarc Apr 17, 2019

bszwarc Apr 17, 2019

bszwarc Apr 17, 2019

bszwarc Apr 17, 2019

JohannesDoberer Apr 17, 2019

bszwarc Apr 17, 2019

bszwarc Apr 17, 2019

bszwarc Apr 17, 2019

bszwarc Apr 17, 2019

bszwarc Apr 17, 2019

	- userInfoFn provides a function to get user information. It returns a promise of an user info object which contains user name and/or email to display it in the profile dropdown.
	- userInfoFn provides a function to get user information. It returns a promise of a user info object which contains user name and/or email to display in the profile dropdown.

	// returns a promise of an userinfo object which contains user name and/or email to display it in the profile dropdown
	// returns a promise of a userinfo object which contains user name and/or email to display in the profile dropdown menu

		- userInfoFn provides a function to get user information. It returns a promise of an user info object which contains user name and/or email to display it in the profile dropdown.


		### Custom Authentification Provider


		### Custom Authentification Provider

		If you are using any authentification provider you also have the possibility to implement some functions that luigi can deal with.

	If you are using any authentification provider you also have the possibility to implement some functions that luigi can deal with.
	If you are using any authentication provider you can also implement some other functions for Luigi to use.

	// returns a promise which contains a error message if something went wrong
	// returns a promise which contains an error message if something went wrong

Display userinfo #484

Display userinfo #484

Conversation

JohannesDoberer commented Apr 15, 2019

maxmarkus left a comment

Choose a reason for hiding this comment

bszwarc left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment