Bug in left navigation #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marynaKhromova
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
JohannesDoberer,
kwiatekus,
maxmarkus,
parostatkiem-zz,
pekura and
y-kkamil
as code owners
pekura
approved these changes
May 14, 2019
jesusreal
reviewed
May 16, 2019
|
|
jesusreal
reviewed
May 23, 2019
core/src/App.html
Outdated
| @@ -545,9 +547,37 @@ | |||
| }); | |||
| }, | |||
| onResize() { | |||
| if (window.innerWidth >= CSS_BREAKPOINTS.desktopMinWidth) { | |||
| const simpleDesktopToMobile = () => { | |||
| if (this.get().responsiveNavSetting == 'simple') { | |||
There was a problem hiding this comment.
Please always use === instead of ==. You will be always be right using ===
core/src/App.html
Outdated
| this.closeLeftNav(); | ||
| } | ||
|
|
||
| simpleDesktopToMobile(); | ||
| this.get().previousBreakpoint = window.innerWidth; |
There was a problem hiding this comment.
Please use better this.set({ previousBreakpoint: window.innerWidth });. Otherwise we are doing a mutation of the component state. It is better to let Svelte do the state updates itself, by just telling Svelte what we want to update with this.set.
jesusreal
suggested changes
May 23, 2019
jesusreal
approved these changes
May 24, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
constants.jsfileviewportmetatag to see the mobile navigation