Modernize luigi client #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
bszwarc,
hardl,
jesusreal,
JohannesDoberer,
kazydek,
marynaKhromova,
pekura and
tomekpapiernik
as code owners
jesusreal
suggested changes
May 28, 2019
core/examples/luigi-sample-angular/e2e/tests/luigi-client-link-manager-features.spec.js
Outdated
Show resolved
Hide resolved
maxmarkus
force-pushed
the
340-modernize-luigi-client
branch
from
f2cd3da to
e3c22cb
Compare
jesusreal
approved these changes
May 29, 2019
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
bszwarc
approved these changes
May 31, 2019
…gi into 340-modernize-luigi-client
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Moved all luigi-client to separate classes and changed var declarations to es6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up Luigi client to separate file per manager and refactored to classes.