Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce luigi client and core bundle size #569

Merged
merged 4 commits into from
Jun 5, 2019
Merged

Reduce luigi client and core bundle size #569

merged 4 commits into from
Jun 5, 2019

Conversation

jesusreal
Copy link
Contributor

What has been done:

  • Remove imports of node´s crypto package in both Luigi Client and Luigi Core
  • Use same implementation of getRandomId for Luigi Client and Luigi Core
  • Bring back pull requests template

@jesusreal jesusreal added the enhancement New feature or request label Jun 3, 2019
@jesusreal jesusreal added this to the Sprint_0 milestone Jun 3, 2019
maxmarkus
maxmarkus approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxmarkus maxmarkus self-assigned this Jun 4, 2019
@marynaKhromova marynaKhromova self-assigned this Jun 4, 2019
marynaKhromova
marynaKhromova approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jesusreal jesusreal merged commit 3e4e177 into SAP:master Jun 5, 2019
@jesusreal jesusreal deleted the reduce-luigi-client-and-core-bundle-size branch June 5, 2019 14:23
@jesusreal jesusreal mentioned this pull request Sep 4, 2019
Closed
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@jesusreal
Reduce Luigi Client and Luigi Core bundle size (SAP#569)
29e5b03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@mmitoraj mmitoraj mmitoraj approved these changes

@kazydek kazydek kazydek approved these changes

@marynaKhromova marynaKhromova marynaKhromova approved these changes

@bszwarc bszwarc Awaiting requested review from bszwarc

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@pekura pekura Awaiting requested review from pekura

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

Assignees

@maxmarkus maxmarkus

@marynaKhromova marynaKhromova

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint_0
Development

Successfully merging this pull request may close these issues.
5 participants
@jesusreal @maxmarkus @mmitoraj @kazydek @marynaKhromova