Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Luigi docs readme file #813

Merged

Conversation

alexandra-simeonova
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova commented Sep 9, 2019

Description

Changes proposed in this pull request:

-Add a link to the Luigi application example
-Add a link to the development guidelines
-Elaborate on the difference between Luigi Core and Luigi Client with 1-2 sentences.

Reason:
I think a lot of people go straight to "docs" when looking for information. It is also linked at the top of the Luigi landing page. It might be useful to include a little more info there.

See also #809

Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things :)

alexandra-simeonova and others added 2 commits September 10, 2019 09:52
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👌

Changes resulting from a 11.09 meeting with the developers
@alexandra-simeonova alexandra-simeonova added documentation documentation tasks WIP Work in progress and removed WIP Work in progress labels Sep 11, 2019
@marynaKhromova marynaKhromova self-assigned this Sep 12, 2019
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@alexandra-simeonova alexandra-simeonova merged commit d628607 into SAP:master Sep 16, 2019
@alexandra-simeonova alexandra-simeonova deleted the improve-docs-readme branch September 16, 2019 06:54
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
* Improve Luigi docs readme file

* Update docs/README.md

Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>

* Update docs/README.md

Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>

* Further improvements

Changes resulting from a 11.09 meeting with the developers

* minor change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation documentation tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants