Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default icon for left nav item when it's collapsed #846

Merged
merged 3 commits into from
Sep 25, 2019
Merged

default icon for left nav item when it's collapsed #846

merged 3 commits into from
Sep 25, 2019

Conversation

marynaKhromova
Copy link
Contributor

@marynaKhromova marynaKhromova commented Sep 23, 2019 •
edited
Loading

Changes proposed in this pull request:

a default icon for the left nav item

Steps to test:

  • go to luigi-sample-angular/src/luigi-config/extended/settings.js and change the settings to responsiveNavigation = 'semiCollapsible';
  • in examples/luigi-sample-angular/src/luigi-config/extended/projectDetailNav.js remove an icon from one of the nodes. (For example for the node 'Go to relative path' remove icon: 'switch-views')
  • in browser go to projects and collapse the left navigation. You will see now the default icon (icon--rhombus) instead of just an empty item.

@marynaKhromova marynaKhromova added the enhancement New feature or request label Sep 23, 2019
@zarkosimic zarkosimic self-assigned this Sep 23, 2019
zarkosimic
zarkosimic approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

JohannesDoberer
JohannesDoberer approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marynaKhromova marynaKhromova merged commit 480f009 into SAP:master Sep 25, 2019
@marynaKhromova marynaKhromova deleted the 841-default-icon-for-a-left-navigation-item branch October 25, 2019 08:50
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@marynaKhromova
default icon for left nav item when it's collapsed (SAP#846)
2cd06b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@zarkosimic zarkosimic zarkosimic approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@pekura pekura Awaiting requested review from pekura

Assignees

@zarkosimic zarkosimic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marynaKhromova @JohannesDoberer @zarkosimic