Improve application-setup.md #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandra-simeonova
requested review from
bszwarc,
kazydek,
mmitoraj and
tomekpapiernik
as code owners
bszwarc
suggested changes
Nov 21, 2019
docs/application-setup.md
Outdated
| [VUE.JS](#vuejs) | ||
|
|
||
| ## Basic application setup | ||
| All those steps are condensed in a single installer script which sets up a Luigi application on your system. Keep in mind that if you have a single page application, you need to transfer it to a two-page application. Your application should run to make sure the existing router doesn't interfere. |
There was a problem hiding this comment.
The last sentence is a bit confusing to me: does it mean that the application needs to be running to check if there is no interference with the router or that you should run it to see if there is no such interference?
There was a problem hiding this comment.
It's the second one :) I changed it to "You should run your application to make sure the existing router doesn't interfere."
There was a problem hiding this comment.
Then I would put it this way - it's more direct and clear.
bszwarc
approved these changes
Nov 21, 2019
alexandra-simeonova
force-pushed
the
improve-app-setup
branch
from
f8b6d10 to
64fcf51
Compare
alexandra-simeonova
force-pushed
the
improve-app-setup
branch
from
423f2d6 to
e44f8c9
Compare
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
alexandra-simeonova
force-pushed
the
improve-app-setup
branch
from
e44f8c9 to
8cf8363
Compare
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Feb 12, 2020
* master: Debug cypress travis issue (SAP#1097) Fix communication from external mf using customMessages (SAP#1081) fix fd-modal mix-up (SAP#1068) who is using luigi in about page (SAP#1077) Add cobrick logo (SAP#1072) who is using luigi button (SAP#1066) Update README.md Update README.md release v0.7.4 (SAP#1069) fix items calculation in more btn of tab nav(SAP#1065) Add valid href to navigation links (SAP#1034) fix runtime error when contextSwitcher is not defined (SAP#1047) Improve API documentation (SAP#1025) Improve authorization doc structure (SAP#1024) Improve Overview page (SAP#1000) Improve application-setup.md (SAP#965) create content guidelines (#877) Documentation fixes (SAP#1003) # Conflicts: # docs/luigi-core-api.md # test/e2e.sh
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* improve application-setup.md Co-authored-by: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the application setup document with better formatting. Before, it was not clear whether the "Basic setup" steps actually had to be performed by the user. The goal is to make the meaning of this section clearer.
See: #955