Third party cookie check #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesDoberer
requested review from
alexandra-simeonova,
bszwarc,
hardl,
jesusreal,
kazydek,
marynaKhromova,
maxmarkus,
mmitoraj,
pekura,
tomekpapiernik and
zarkosimic
as code owners
docs/general-settings.md
Outdated
|
|
||
| - **thirdPartyCookiesScriptLocation** is the URL to the page containing third-party cookies support check. | ||
| To detect whether the user's browser supports the mechanism, use the script in the third-party-cookies catalog. Deploy these files on a domain different from your main application's and set thirdPartyCookiesScriptLocation to the init.html file. During initialization, Luigi detects the cookies support and produces an alert if cookies are disabled in the user's browser. | ||
| * **thirdPartyCookieDetection** is a flag to check if third party cookies are supported. When set to `true`, Luigi detects during initialization of an external microfrontend the cookie support and produces an alert if cookies are disabled in the user's browsers. |
There was a problem hiding this comment.
Suggested change
| * **thirdPartyCookieDetection** is a flag to check if third party cookies are supported. When set to `true`, Luigi detects during initialization of an external microfrontend the cookie support and produces an alert if cookies are disabled in the user's browsers. | |
| * **thirdPartyCookieDetection** is a flag to check if third-party cookies are supported. When set to `true`, Luigi detects cookie support during the initialization of an external micro frontend and produces an alert if cookies are disabled in the user's browsers. |
Co-Authored-By: Alexandra Simeonova <49867570+alexandra-simeonova@users.noreply.github.com>
…ck' of github.com:JohannesDoberer/luigi into third-party-cookie-check * 'third-party-cookie-check' of github.com:JohannesDoberer/luigi: Update docs/general-settings.md * 'third-party-cookie-check' of github.com:JohannesDoberer/luigi: Update docs/general-settings.md
Co-Authored-By: Alexandra Simeonova <49867570+alexandra-simeonova@users.noreply.github.com>
…/luigi into third-party-cookie-check * 'third-party-cookie-check' of github.com:JohannesDoberer/luigi:
pekura
approved these changes
Nov 25, 2019
…/luigi into third-party-cookie-check * 'third-party-cookie-check' of github.com:JohannesDoberer/luigi: FAQ Documentation (SAP#982) Docu links leftovers (SAP#974) Bugfix invalid initial root navnode (SAP#979) Leftover documentation fixes (SAP#978) Navigate with anchors (SAP#976) remove jesusreal from codeowners, thanks for your great work in this project (SAP#980)
* master: remove icon preview page (SAP#988)
Co-Authored-By: Alexandra Simeonova <49867570+alexandra-simeonova@users.noreply.github.com>
Co-Authored-By: Alexandra Simeonova <49867570+alexandra-simeonova@users.noreply.github.com>
pekura
reviewed
Nov 28, 2019
core/src/App.html
Outdated
| thirdPartyCookiesCheck = LuigiConfig.getConfigValue( | ||
| 'settings.thirdPartyCookieCheck' | ||
| ); | ||
| if (thirdPartyCookiesCheck.thirdPartyCookieScriptLocation) { |
There was a problem hiding this comment.
thirdPartyCookiesCheck can be null or undefined here..
alexandra-simeonova
approved these changes
Nov 28, 2019
Co-Authored-By: Alexandra Simeonova <49867570+alexandra-simeonova@users.noreply.github.com>
Co-Authored-By: Alexandra Simeonova <49867570+alexandra-simeonova@users.noreply.github.com>
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Nov 29, 2019
JohannesDoberer
added a commit
to JohannesDoberer/luigi
that referenced
this pull request
Dec 4, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.