Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Create ResourceBundle asynchronously #251

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Oct 16, 2024

Models defined in the manifest.json are created asynchronously per default. The ResourceBundle not. Here its required to set the async flag manually.

@flovogt flovogt requested a review from a team October 16, 2024 07:22
d3xter666
d3xter666 previously approved these changes Oct 16, 2024
Copy link
Contributor

@d3xter666 d3xter666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@flovogt flovogt marked this pull request as draft October 16, 2024 11:30
@flovogt flovogt force-pushed the make-resourcebundle-async branch 2 times, most recently from b10e12a to 10b0a45 Compare October 17, 2024 13:49
@flovogt flovogt marked this pull request as ready for review October 17, 2024 14:04
@flovogt flovogt merged commit 8ff64b4 into main Oct 18, 2024
7 checks passed
@flovogt flovogt deleted the make-resourcebundle-async branch October 18, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants