Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need new release (for date range issue fix) #176

Closed
bneijt opened this issue Aug 24, 2021 · 3 comments
Closed

Need new release (for date range issue fix) #176

bneijt opened this issue Aug 24, 2021 · 3 comments
Assignees

Comments

@bneijt
Copy link

bneijt commented Aug 24, 2021

I'm connecting to an SAP system en running into issue #143 for which there is a fix on master via merge #149 .

However, there has not been a release since then.

What needs to be done to get a new release published with this fix?

@phanak-sap
Copy link
Contributor

phanak-sap commented Aug 25, 2021

True that it is a long time ago. Will work on releasing 1.7.1 with the bugfixes.

As a dirty, quick fix workaround, you can always install (recomend in python virtualenv) pip from repository, using specified git commit, e.g. https://stackoverflow.com/questions/13685920/install-specific-git-commit-with-pip. You can use your fix immediately.

(Wanted to release 1.8.0 after merging of #154 but there will be some changes and so you are right, no need for waiting.)

@phanak-sap phanak-sap self-assigned this Aug 25, 2021
@bneijt
Copy link
Author

bneijt commented Aug 26, 2021

Great, let me know if you would like help with setting up CI and/or poetry to make managing and packaging easier. I've already done something similar for my own repositories so should not be to much work to set up a PR to add that here.

@phanak-sap
Copy link
Contributor

1.7.1 including your fix released.

https://pypi.org/project/pyodata/1.7.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants