Workaround for screwed up date values #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds constant FIX_SCREWED_UP_MINIMAL_DATETIME_VALUE to return 0001-01-01 - Adds constant FIX_SCREWED_UP_MAXIMUM_DATETIME_VALUE to return 9999-12-31 - Add new unittests
|
|
|
Looks good to me. Thank you! |
|
@filak-sap thanks for accepting my pull request. Will there be a offical release soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #143
FIX_SCREWED_UP_MINIMAL_DATETIME_VALUEto return 0001-01-01FIX_SCREWED_UP_MAXIMUM_DATETIME_VALUEto return 9999-12-31