Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support customization for logger dev mode #406

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

gadisn
Copy link
Contributor

@gadisn gadisn commented Mar 4, 2024

Pull Request Template

Prerequisites

Motivation

When the log from btp operator is sent to a log system, e.g. OpenSearch, it make sense to turn off the dev mode, so the format will be json - which is simpler to process as structured fields

Approach

Use the btp chart with custom values I'll set manager.logger_use_dev_mode to false, so the log will be created in json format

Pull Request status

  • Implementation

Feel free to construct the checklist with whatever items seem most reasonable for your change. You could disassemble the Implementation part to even smaller separate checklist items if you're working on something big for example. But do make the effort to provide a checklist of some sort so that the core team as well as the community can have an idea about the progress of your Pull Request.

Third-party code

If you use third party code with your contribution such as, components, libraries, or snippets make sure to mention that.

Work in Progress label

For as long as development of your Pull Request is still ongoing you MUST label it with a wip label as well as prefix the name of the PR with [WIP].

For example: [WIP] Service brokers API

gadisn added 3 commits March 4, 2024 09:10
 When the log from btp operator is sent to a log system, e.g. OpenSearch, it make sense to turn off the dev mode, so the format will be json - which is simpler to process as structured fields
@gadisn gadisn changed the title [WIP]feat: support customization for logger dev mode feat: support customization for logger dev mode Mar 4, 2024
@gadisn
Copy link
Contributor Author

gadisn commented Mar 12, 2024

@kerenlahav can this PR be merged? I don't have permissions. Thanks

@kerenlahav kerenlahav merged commit 444263a into SAP:main Mar 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants