Skip to content

Commit

Permalink
Remove bootstrap imports from feature libs (#19853)
Browse files Browse the repository at this point in the history
  • Loading branch information
kpawelczak authored Jan 16, 2025
1 parent fd138eb commit b1a08b4
Show file tree
Hide file tree
Showing 46 changed files with 325 additions and 51 deletions.
4 changes: 0 additions & 4 deletions feature-libs/cart/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
@import '@spartacus/styles/scss/cxbase/blocks/modal';
@import '@spartacus/styles/scss/misc/table';

@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/_mixins';

@mixin visible-focus {
outline-style: solid;
outline-color: var(--cx-color-visual-focus);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ export class CartBaseFeatureModule { }
exports[`Spartacus Cart schematics: ng-add Cart Base feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/cart";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -263,6 +266,9 @@ export class CartImportExportFeatureModule { }
exports[`Spartacus Cart schematics: ng-add Cart Import Export feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/cart";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -448,6 +454,9 @@ export class CartQuickOrderFeatureModule { }
exports[`Spartacus Cart schematics: ng-add Quick Order feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/cart";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -633,6 +642,9 @@ export class CartSavedCartFeatureModule { }
exports[`Spartacus Cart schematics: ng-add Saved Cart feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/cart";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -828,6 +840,9 @@ export class WishListFeatureModule { }
exports[`Spartacus Cart schematics: ng-add Wish List feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/cart";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
4 changes: 0 additions & 4 deletions feature-libs/checkout/_index.scss
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
@import '@spartacus/styles/scss/core';

@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/mixins';

@import './base/index';
@import './b2b/index';
@import './scheduled-replenishment/index';
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ export class CheckoutWrapperModule { }
exports[`Spartacus Checkout schematics: ng-add Checkout feature b2b general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/checkout";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -315,6 +318,9 @@ export class CheckoutFeatureModule { }
exports[`Spartacus Checkout schematics: ng-add Checkout feature base general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/checkout";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -594,6 +600,9 @@ export class CheckoutWrapperModule { }
exports[`Spartacus Checkout schematics: ng-add Checkout feature scheduled replenishment general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/checkout";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
5 changes: 0 additions & 5 deletions feature-libs/organization/_index.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
@import '@spartacus/styles/scss/core';

// we require a few bootstrap files for the CSS in this code
@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/_mixins';

@mixin visible-focus {
outline-style: solid;
outline-color: var(--cx-color-visual-focus);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ export class OrganizationAccountSummaryFeatureModule { }
exports[`Spartacus Organization schematics: ng-add Account summary feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/organization";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -313,6 +316,9 @@ export class OrganizationAdministrationFeatureModule { }
exports[`Spartacus Organization schematics: ng-add Administration feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/organization";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -533,6 +539,9 @@ export class OrganizationOrderApprovalFeatureModule { }
exports[`Spartacus Organization schematics: ng-add Order approval feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/organization";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -753,6 +762,9 @@ export class OrganizationUnitOrderFeatureModule { }
exports[`Spartacus Organization schematics: ng-add Unit order feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/organization";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -973,6 +985,9 @@ export class OrganizationUserRegistrationFeatureModule { }
exports[`Spartacus Organization schematics: ng-add User registration feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/organization";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
4 changes: 0 additions & 4 deletions feature-libs/pickup-in-store/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,4 @@ $cx-color-link-primary: #1672b7;
@import '@spartacus/styles/scss/cxbase/blocks/modal';
@import '@spartacus/styles/scss/misc/table';

@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/_mixins';

@import './styles/index';
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ export class PickupInStoreFeatureModule { }
exports[`Spartacus Pickup in Store schematics: ng-add Pick Up In Store feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/pickup-in-store";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
4 changes: 0 additions & 4 deletions feature-libs/product-multi-dimensional/_index.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
@import '@spartacus/styles/scss/core';
// we require a few bootstrap files for the CSS in this code
@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/_mixins';

@import './selector/index';
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,9 @@ export class ProductMultiDimensionalSelectorFeatureModule { }
exports[`Spartacus Product Multi-Dimensional schematics: ng-add selector feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/product-multi-dimensional";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
4 changes: 0 additions & 4 deletions feature-libs/product/_index.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
@import '@spartacus/styles/scss/core';
// we require a few bootstrap files for the CSS in this code
@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/_mixins';

@mixin visible-focus {
outline-style: solid;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ export class ProductBulkPricingFeatureModule { }
exports[`Spartacus Product schematics: ng-add BulkPricing feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/product";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -313,6 +316,9 @@ export class ProductFutureStockFeatureModule { }
exports[`Spartacus Product schematics: ng-add FutureStock feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/product";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -498,6 +504,9 @@ export class ProductImageZoomFeatureModule { }
exports[`Spartacus Product schematics: ng-add ImageZoom feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/product";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down Expand Up @@ -683,6 +692,9 @@ export class ProductVariantsFeatureModule { }
exports[`Spartacus Product schematics: ng-add Variants feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/product";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
4 changes: 0 additions & 4 deletions feature-libs/qualtrics/_index.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
@import '@spartacus/styles/scss/core';
// we require a few bootstrap files for the CSS in this code
@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/_mixins';

@import './styles/index';
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ export class QualtricsFeatureModule { }
exports[`Spartacus Qualtrics schematics: ng-add Qualtrics feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/qualtrics";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
4 changes: 0 additions & 4 deletions feature-libs/quote/_index.scss
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
@import '@spartacus/styles/scss/core';
@import '@spartacus/styles/scss/app';

@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/_mixins';

@mixin visible-focus {
outline-style: solid;
outline-color: var(--cx-color-visual-focus);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ export class QuoteFeatureModule { }
exports[`Spartacus Quote schematics: ng-add Quote feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/quote";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ export class StoreFinderFeatureModule { }
exports[`Spartacus Storefinder schematics: ng-add Storefinder feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/storefinder";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
4 changes: 0 additions & 4 deletions feature-libs/storefinder/styles/_index.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/mixins';

@import './components/index';
@import './layout/index';
4 changes: 0 additions & 4 deletions integration-libs/epd-visualization/_index.scss
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
@import '@spartacus/styles/scss/core';

@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/_mixins';

@import './styles/index';

$epd-visualization-components-allowlist: cx-epd-visualization-viewer,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ export class EpdVisualizationFeatureModule { }
exports[`Spartacus SAP EPD Visualization integration schematics: ng-add SAP EPD Visualization feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/epd-visualization";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
4 changes: 1 addition & 3 deletions integration-libs/opf/_index.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
@import '@spartacus/styles/scss/core';
@import '@spartacus/checkout';
@import '@spartacus/styles/vendor/bootstrap/scss/functions';
@import '@spartacus/styles/vendor/bootstrap/scss/variables';
@import '@spartacus/styles/vendor/bootstrap/scss/_mixins';

@import './base/styles/index';
@import './checkout/styles/index';
@import './cta/styles/index';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ exports[`Spartacus SAP OPF integration schematics: ng-add SAP OPF feature genera
exports[`Spartacus SAP OPF integration schematics: ng-add SAP OPF feature general setup styling should create a proper scss file 1`] = `
"@import "../../styles-config";
@import "@spartacus/opf";
@import "@spartacus/styles/vendor/bootstrap/scss/functions";
@import "@spartacus/styles/vendor/bootstrap/scss/variables";
@import "@spartacus/styles/vendor/bootstrap/scss/_mixins";
"
`;
Expand Down
Loading

0 comments on commit b1a08b4

Please sign in to comment.