-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CXSPA-5903 Schematics - add provideHttpClient(withFetch(), withInterceptorsFromDi())
in fresh applications
#18443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fresh applications - `provideHttpClient(withFetch()) instead of `HttpClientModule` in fresh Spartacus applications - adjust logic responsible for removing `provideClientHydration` to remove only intended provider - `provideHttpClient(withFetch()) instead of `HttpClientModule` in storefront app module - unit tests adjustments
4 flaky tests on run #42560 ↗︎
Details:
Review all test suite changes for PR #18443 ↗︎ |
Platonn
reviewed
Feb 5, 2024
provideHttpClient(withFetch())
in fresh applicationsprovideHttpClient(withFetch(), withInterceptorsFromDi())
in fresh applications
Platonn
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QAd. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes related usage of
provideHttpClient(withFetch(), withInterceptorsFromDi())
in new Spartacus applications as well as in our internal storefront application. Such a change allows us to avoid warning during Spartacus installation:This change is applied for both client-side rendering and server-side rendering.
In addition to
withFetch
config,withInterceptorsFromDi
has to be applied to include class-based interceptors configured using a multi-provider in the injector into the configured HttpClient instance.Changes:
provideHttpClient(withFetch())
instead ofHttpClientModule
in fresh Spartacus applicationsprovideClientHydration
to remove only the intended providerprovideHttpClient(withFetch())
instead ofHttpClientModule
in the storefront app moduleQA steps:
CSR:
npx ts-node ./tools/schematics/testing.ts
in the SPA root foldernpx @angular/cli new my-app --standalone=false --ssr=false --style=scss
npx @angular/cli add @spartacus/schematics@latest --baseUrl="https://40.76.109.9:9002"
app.module.ts
containsprovideHttpClient(withFetch(), withInterceptorsFromDi())
configurationnpm run start
to verify if the app worksSSR:
npx ts-node ./tools/schematics/testing.ts
in the SPA root foldernpx @angular/cli new my-app --standalone=false --ssr=false --style=scss
npx @angular/cli add @spartacus/schematics@latest --baseUrl="https://40.76.109.9:9002" --ssr
app.module.ts
containsprovideHttpClient(withFetch(), withInterceptorsFromDi())
configuration (the additional coma is related to the removal ofprovideClientHydration
feature)npm run build
andnpm run serve:ssr:my-app
to verify if the app workscloses CXSPA-5903