Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (CXSPA-9098)-Coupon Codes is used in Coupon Campaign URL #19739

Merged
merged 28 commits into from
Dec 24, 2024
Merged

fix: (CXSPA-9098)-Coupon Codes is used in Coupon Campaign URL #19739

merged 28 commits into from
Dec 24, 2024

Conversation

crisli001
Copy link
Contributor

… for SPA UI

@crisli001 crisli001 marked this pull request as ready for review December 10, 2024 03:21
@crisli001 crisli001 requested review from a team as code owners December 10, 2024 03:21
@crisli001 crisli001 requested a review from ssisali December 10, 2024 03:22
@cypress Cypress
Copy link

cypress bot commented Dec 10, 2024 •
edited
Loading

spartacus    Run #46468

Run Properties:  status check passed Passed #46468  •  git commit d46481ff7a ℹ️: Merge 1722b0da9f0d10c870fdc29d8f5a5f902d9774b9 into 5d7b4cbce8f465e8cccb2121159d...
Project spartacus
Branch Review bugfix/CXSPA-9098
Run status status check passed Passed #46468
Run duration 03m 54s
Commit git commit d46481ff7a ℹ️: Merge 1722b0da9f0d10c870fdc29d8f5a5f902d9774b9 into 5d7b4cbce8f465e8cccb2121159d...
Committer crisli001
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft December 10, 2024 07:46
@crisli001 crisli001 marked this pull request as ready for review December 10, 2024 08:37
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft December 10, 2024 08:51
@crisli001 crisli001 marked this pull request as ready for review December 10, 2024 08:51
rmch91
rmch91 requested changes Dec 17, 2024
View reviewed changes
projects/core/src/occ/adapters/user/occ-customer-coupon.adapter.ts Show resolved Hide resolved
projects/core/src/user/connectors/customer-coupon/customer-coupon.connector.ts Outdated Show resolved Hide resolved
...s/storefrontlib/cms-components/myaccount/my-coupons/claim-dialog/claim-dialog.component.html Outdated Show resolved Hide resolved
...s/storefrontlib/cms-components/myaccount/my-coupons/claim-dialog/claim-dialog.component.html Outdated Show resolved Hide resolved
...s/storefrontlib/cms-components/myaccount/my-coupons/claim-dialog/claim-dialog.component.html Outdated Show resolved Hide resolved
...cts/storefrontlib/cms-components/myaccount/my-coupons/claim-dialog/claim-dialog.component.ts Outdated Show resolved Hide resolved
...cts/storefrontlib/cms-components/myaccount/my-coupons/claim-dialog/claim-dialog.component.ts Outdated Show resolved Hide resolved
...cts/storefrontlib/cms-components/myaccount/my-coupons/claim-dialog/claim-dialog.component.ts Outdated Show resolved Hide resolved
projects/storefrontlib/cms-components/myaccount/my-coupons/my-coupons.component.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot marked this pull request as draft December 18, 2024 09:46
@crisli001 crisli001 marked this pull request as ready for review December 18, 2024 09:46
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft December 18, 2024 09:58
@crisli001 crisli001 marked this pull request as ready for review December 18, 2024 09:58
@crisli001 crisli001 changed the title CXSPA-9098, fix the issue Coupon Codes is used in Coupon Campaign URL… fix: (CXSPA-9098)-fix the issue Coupon Codes is used in Coupon Campaign URL… Dec 18, 2024
@crisli001 crisli001 marked this pull request as ready for review December 20, 2024 02:00
@crisli001
Copy link
Contributor Author

Hi @rmch91 , I have updated cypress test cases, could you help re-run the whole cypress tests and review the PR again?
Thanks a lot.

@github-actions github-actions bot marked this pull request as draft December 22, 2024 06:22
@crisli001 crisli001 marked this pull request as ready for review December 22, 2024 06:29
@github-actions github-actions bot marked this pull request as draft December 22, 2024 06:57
@crisli001 crisli001 marked this pull request as ready for review December 22, 2024 06:57
@github-actions github-actions bot marked this pull request as draft December 23, 2024 03:43
@crisli001 crisli001 marked this pull request as ready for review December 23, 2024 03:43
@github-actions github-actions bot marked this pull request as draft December 23, 2024 05:52
@crisli001 crisli001 marked this pull request as ready for review December 23, 2024 05:54
@github-actions github-actions bot marked this pull request as draft December 23, 2024 07:29
@crisli001 crisli001 marked this pull request as ready for review December 23, 2024 07:30
@github-actions github-actions bot marked this pull request as draft December 23, 2024 08:51
@crisli001 crisli001 marked this pull request as ready for review December 23, 2024 08:52
@crisli001 crisli001 merged commit 59c62a4 into develop Dec 24, 2024
61 of 67 checks passed
@crisli001 crisli001 deleted the bugfix/CXSPA-9098 branch December 24, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmch91 rmch91 rmch91 approved these changes

@ssisali ssisali Awaiting requested review from ssisali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisli001 @rmch91