Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CXCDS-13558: Change implementation for Spartacus CAS support #19869

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

CXCDS-13558: Change implementation for Spartacus CAS support #19869

wants to merge 9 commits into from

Conversation

johannathalmann-SAP
Copy link
Contributor

We removed the feature toggle implementation since we have to support CAS* and non CAS customers for a while.
CAS support should be based on a configuration change.

  • CAS only to be used internally, so we use the term SCI: "CDS/ISS is integrated into the SAP Cloud Identity Service (SCI). The downstream services use different domains and URL formats. This property enables the CDS module to use these new URLs."

@johannathalmann-SAP johannathalmann-SAP marked this pull request as ready for review January 16, 2025 10:07
@johannathalmann-SAP johannathalmann-SAP requested review from a team as code owners January 16, 2025 10:07
@cypress Cypress
Copy link

cypress bot commented Jan 16, 2025 •
edited
Loading

spartacus    Run #46709

Run Properties:  status check passed Passed #46709  •  git commit 353c67c413 ℹ️: Merge 79b1166f8689cbf1026b2b43999c1ceecce48784 into 172ffe4f540a9ea21965dffcab29...
Project spartacus
Branch Review feature/CXCDS-13558
Run status status check passed Passed #46709
Run duration 03m 52s
Commit git commit 353c67c413 ℹ️: Merge 79b1166f8689cbf1026b2b43999c1ceecce48784 into 172ffe4f540a9ea21965dffcab29...
Committer johannathalmann-SAP
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

klucerofermin
klucerofermin requested changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@klucerofermin klucerofermin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the configUrl (what we already talked in the call)

@github-actions github-actions bot marked this pull request as draft January 17, 2025 12:18
@johannathalmann-SAP johannathalmann-SAP marked this pull request as ready for review January 17, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpawelczak kpawelczak kpawelczak left review comments

@klucerofermin klucerofermin klucerofermin approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johannathalmann-SAP @kpawelczak @klucerofermin