Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CXSPA-9318 [PoC] Migrate storefrontapp to 'application' builder #20011

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pawelfras
Copy link
Contributor

@pawelfras pawelfras commented Feb 21, 2025

This PR contains PoC of migration to 'application' builder. The goal is to use modern builder sample storefrontapp default for the fresh Angular applications and to be as close as possible to applications created by our customers.

Remaining work:

  • enable using aliases in .scss files
    • previously it was handled by extra-webpack.config.js, but new builder uses esbuild under the hood
    • Note: for testing purposes, this PR uses paths to libraries inside monorepo, which is possible thanks to stylePreprocessorOptions -> includePaths config in project.json BUT we cannot use this approach as styles that are part of our libraries need to use aliases to work in customers` applications
    • handle esbuild warnings:
      image
  • handle CSR build
    • because application builder handles CSR and SSR build and when SSR is configured, its default ng build produces SSR, we need to find the way how to build only CSR app
  • verify if and how migration to application builder affects:
    • CI/CD
    • installation script
    • jenkins job/CCv2 deployment

@pawelfras pawelfras requested review from a team as code owners February 21, 2025 10:56
@github-actions github-actions bot marked this pull request as draft February 21, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant