Skip to content

Commit

Permalink
Added TODO for descriptorVersion parameter
Browse files Browse the repository at this point in the history
The descriptorVersion parameter is not public API, but it makes sense
to make the parameter of type string and create a SemVer object inside.
  • Loading branch information
tobiasso85 committed Feb 25, 2021
1 parent f7ae8bc commit 9cd1313
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/processors/manifestCreator.js
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ async function createManifest(libraryResource, libBundle, descriptorVersion, _in
module.exports = function({libraryResource, resources, options}) {
// merge options with defaults
options = Object.assign({
descriptorVersion: APP_DESCRIPTOR_V22,
descriptorVersion: APP_DESCRIPTOR_V22, // TODO change this to type string instead of a semver object
include3rdParty: true,
prettyPrint: true
}, options);
Expand Down

0 comments on commit 9cd1313

Please sign in to comment.