Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] manifestEnhancer: Only use valid files for supportedLocales #1080

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[FIX] manifestEnhancer: Only use valid files for supportedLocales #1080

wants to merge 6 commits into from
+248 −19

Commits on Oct 7, 2024

  1. [FIX] manifestEnhancer: Only use valid files for supportedLocales 

    This fixes two problems that could have occurred:

A properties file with an invalid locale was still taken into the list
of supported locales, which then caused a runtime exception in the
ResourceBundle as it validates the input.

Another problem was that properties files could have a valid name
according to BCP47, but the file won't be ever requested with that name.
This is due to the fact that the ResourceBundle does not use the
extension / private use sections of the locale when creating the request
URL.

In both cases, the properties file is now ignored and no entry for the
supportedLocales is created.
    @matz3
    matz3 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2dc6923 View commit details
    Browse the repository at this point in the history

  2. [INTERNAL] Log warning + prevent duplicate messages

    @matz3
    matz3 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    f88a759 View commit details
    Browse the repository at this point in the history

  3. [INTERNAL] Improve locale check and handle specal case of sr_Latn

    @matz3
    matz3 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e3face7 View commit details
    Browse the repository at this point in the history

  4. [INTERNAL] Rename sapprc to saptrc 

    sapprc is not a valid supportability locale
    @matz3
    matz3 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    646061f View commit details
    Browse the repository at this point in the history

  5. [INTERNAL] Update expected build results

    @matz3
    matz3 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    31c02fd View commit details
    Browse the repository at this point in the history

  6. [INTERNAL] Validate variants and generated locales against BCP47

    @matz3
    matz3 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2745dba View commit details
    Browse the repository at this point in the history