-
Notifications
You must be signed in to change notification settings - Fork 24
[INTERNAL] generateLibraryPreload: Add experimental bundle-info preload #1170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
To be clarified: Should this be released as a pre-release of UI5 Builder and UI5 CLI (requires dedicated release pipeline) or as regular patches (with an empty changelog)? I would prefer the first option. |
17ba0e0 to
881bab4
Compare
As discussed with @matz3, we tend to release this as a regular patch and consume it in the regular way. |
881bab4 to
e9c7528
Compare
e9c7528 to
476e3bb
Compare
|
Somehow review comments that I had made, went lost. Please wait with a merge, I'll redo the comments. |
Oh no! I force pushed, but PR comments should have been preserved. Did you maybe comment directly on the commit? |
|
Not sure, maybe. Indeed, while I was reviewing, you force pushed in parallel. |
…rimental library-preload
codeworrior
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For internal PoC usage.
This change is not active in regular builds. To activate it, the environment variable
UI5_CLI_EXPERIMENTAL_BUNDLE_INFO_PRELOADneeds to be set to any value.JIRA: CPOUI5FOUNDATION-1165