Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add bundling sap-ui-core-noJQuery.js and sap-ui-core-noJQuery-dbg.js #227

Merged
merged 7 commits into from
Apr 2, 2019
Merged

[FIX] Add bundling sap-ui-core-noJQuery.js and sap-ui-core-noJQuery-dbg.js #227

merged 7 commits into from
Apr 2, 2019

Conversation

devtomtom
Copy link
Member

matz3
matz3 requested changes Mar 28, 2019
View reviewed changes
lib/tasks/bundlers/generateLibraryPreload.js Outdated Show resolved Hide resolved
lib/tasks/bundlers/generateLibraryPreload.js Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 29, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 84.817% when pulling 648a7a7 on add-bundle-sap-ui-core-noJQuery into 3bf0f56 on master.

matz3
matz3 reviewed Apr 1, 2019
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. We still don't have integration tests for this, right? So at least a manual test should be done to see whether the bundles still work as expected.

@devtomtom devtomtom merged commit 71e0a1f into master Apr 2, 2019
@devtomtom devtomtom deleted the add-bundle-sap-ui-core-noJQuery branch April 2, 2019 08:40
@RandomByte RandomByte restored the add-bundle-sap-ui-core-noJQuery branch April 2, 2019 08:51
@devtomtom devtomtom mentioned this pull request Apr 2, 2019
Merged
@RandomByte
Copy link
Member

Will be merged as #235

@devtomtom devtomtom deleted the add-bundle-sap-ui-core-noJQuery branch April 2, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

@RandomByte RandomByte Awaiting requested review from RandomByte

@codeworrior codeworrior Awaiting requested review from codeworrior

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devtomtom @coveralls @RandomByte @matz3