[BREAKING] LibraryFormatter: Ignore manifest.json of nested apps #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
library-handle-nested-apps-manifest
branch
from
14c221e
to
e7239a8
Compare
RandomByte
force-pushed
the
library-handle-nested-apps-manifest
branch
from
e7239a8
to
6ac1e3d
Compare
RandomByte
force-pushed
the
library-handle-nested-apps-manifest
branch
from
6ac1e3d
to
c79169e
Compare
RandomByte
changed the title
|
I think it would make sense to add this to the 2.0 release. |
RandomByte
force-pushed
the
library-handle-nested-apps-manifest
branch
from
c79169e
to
93a8171
Compare
If a library contains a nested application project or similar, do not assume that projects manifest.json to be relevant for the library itself in case it does not feature a manifest.json. Instead try to identify such situations by checking whether the .library file and the manifest.json are on the same directory level. BREAKING CHANGE: If a library contains both, a manifest.json and .library file, they must either be located in the same directory or the manifest.json is ignored. In cases where the manifest.json is located on a higher level or different directory on the same level than a .library file, an exception is thrown.
RandomByte
force-pushed
the
library-handle-nested-apps-manifest
branch
from
93a8171
to
7a435c2
Compare
matz3
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a library contains a nested application project or similar, do not
assume that projects manifest.json to be relevant for the library itself
in case it does not feature a manifest.json.
Instead try to identify such situations by checking whether the
.library file and the manifest.json are on the same directory level.
BREAKING CHANGE:
If a library contains both, a manifest.json and .library file, they must
either be located in the same directory or the manifest.json is ignored.
In cases where the manifest.json is located on a higher level or
different directory on the same level than a .library file, an exception
is thrown.