Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Bundler: Improve error log messages #466

Merged
merged 3 commits into from
Sep 4, 2020
Merged

[FIX] Bundler: Improve error log messages #466

merged 3 commits into from
Sep 4, 2020

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jun 3, 2020 •
edited
Loading

No description provided.

@coveralls
Copy link

coveralls commented Jun 3, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 92.745% when pulling 4906f56 on improve-lbt-error-messages into 03b1aef on master.

tobiasso85
tobiasso85 reviewed Aug 20, 2020
View reviewed changes
Copy link
Contributor

@tobiasso85 tobiasso85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having stack traces in the log will flood it, would it make sense to have the stack traces logged with debug/verbose? and the error message with error?

@tobiasso85 tobiasso85 force-pushed the improve-lbt-error-messages branch 2 times, most recently from 29e177b to b279fe2 Compare August 26, 2020 12:21
@matz3 matz3 changed the title WIP: LBT improve error messages Improve error messages Aug 27, 2020
@matz3 matz3 marked this pull request as ready for review August 31, 2020 07:26
@matz3 matz3 force-pushed the improve-lbt-error-messages branch from 2c896ea to 3f9447d Compare August 31, 2020 07:29
tobiasso85
tobiasso85 approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@tobiasso85 tobiasso85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3 matz3 changed the title Improve error messages [FIX] Bundler: Improve error log messages Sep 4, 2020
@matz3 matz3 merged commit 6bb6235 into master Sep 4, 2020
@matz3 matz3 deleted the improve-lbt-error-messages branch September 4, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasso85 tobiasso85 tobiasso85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matz3 @coveralls @tobiasso85