[FEATURE] Add Library/Component preload exclude configuration #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sap.ui.core excludes from .library look like this: "builder": {
"libraryPreload": {
"excludes": [
"jquery-*.js",
"sap-*",
"sap/ui/core/plugin/DeclarativeSupport.js",
"sap/ui/core/plugin/LessSupport.js",
"sap/ui/debug/**",
"sap/ui/core/support/",
"sap/ui/qunit/**",
"sap/ui/test/**",
"testsuite/**",
"jquery-ui-core.js",
"jquery-ui-datepicker.js",
"jquery-ui-position.js",
"sap/ui/model/odata/datajs.js",
"sap/ui/thirdparty/bignumber.js",
"sap/ui/thirdparty/blanket.js",
"sap/ui/thirdparty/d3.js",
"sap/ui/thirdparty/datajs.js",
"sap/ui/thirdparty/es6-object-assign.js",
"sap/ui/thirdparty/es6-string-methods.js",
"sap/ui/thirdparty/flexie.js",
"sap/ui/thirdparty/handlebars.js",
"sap/ui/thirdparty/IPv6.js",
"sap/ui/thirdparty/iscroll.js",
"sap/ui/thirdparty/iscroll-lite.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-widget.js",
"sap/ui/thirdparty/jqueryui/jquery-effect*.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-blind.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-bounce.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-clip.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-drop.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-explode.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-fade.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-fold.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-highlight.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-pulsate.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-scale.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-shake.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-slide.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-effect-transfer.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-mouse.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-draggable.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-resizable.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-selectable.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-sortable.js",
"sap/ui/thirdparty/jqueryui/jquery-ui-droppable.js",
"sap/ui/thirdparty/jszip.js",
"sap/ui/thirdparty/klay.js",
"sap/ui/thirdparty/less.js",
"sap/ui/thirdparty/mobify-carousel.js",
"sap/ui/thirdparty/mobiscroll/js/mobiscroll-core.js",
"sap/ui/thirdparty/mobiscroll/js/mobiscroll-scroller.js",
"sap/ui/thirdparty/mobiscroll/js/mobiscroll-datetime.js",
"sap/ui/thirdparty/punycode.js",
"sap/ui/thirdparty/qunit-2.js",
"sap/ui/thirdparty/qunit-composite.js",
"sap/ui/thirdparty/qunit-reporter-junit.js",
"sap/ui/thirdparty/qunit.js",
"sap/ui/thirdparty/RequestRecorder.js",
"sap/ui/thirdparty/require.js",
"sap/ui/thirdparty/SecondLevelDomains.js",
"sap/ui/thirdparty/sinon-4.js",
"sap/ui/thirdparty/sinon-ie.js",
"sap/ui/thirdparty/sinon-qunit.js",
"sap/ui/thirdparty/sinon-server.js",
"sap/ui/thirdparty/sinon.js",
"sap/ui/thirdparty/swipe-view.js",
"sap/ui/thirdparty/unorm.js",
"sap/ui/thirdparty/unormdata.js",
"sap/ui/thirdparty/URITemplate.js",
"sap/ui/thirdparty/vkbeautify.js",
"sap/ui/thirdparty/zyngascroll.js",
"sap/ui/thirdparty/hyphenopoly/**"
]
}
} |
|
@RandomByte for sap.ui.core library-preload.js we need to have a custom bundle definition, as there are multiple namespaces to be included. |
RandomByte
reviewed
Feb 2, 2021
codeworrior
reviewed
Feb 5, 2021
This prevents potential misinterpretation of paths that start with +, - or ! Calling negatFilters an even number of times will give now always return a value that is semantically equal to the initial input.
RandomByte
force-pushed
the
preload-excludes
branch
from
3f4624b
to
aaee1bb
Compare
RandomByte
approved these changes
Feb 9, 2021
matz3
changed the title
KlattG
reviewed
Feb 10, 2021
RandomByte
added a commit
that referenced
this pull request
Mar 9, 2021
…penUI5 theme libraries Exception handling was already in place for legacy OpenUI5 theme libraries that still use type 'library' instead of 'theme-library': #437 This allowed them to still be formatted even though they are missing a .library file. However, the newly added preload exclude configuration fallback for framework libraries also requires a .library file and did not make the mentioned exception for legacy OpenUI5 theme libraries: #573 This fix adds that exception and the tests that were missing from #437
RandomByte
added a commit
that referenced
this pull request
Mar 9, 2021
…penUI5 theme libraries Exception handling was already in place for legacy OpenUI5 theme libraries that still use type 'library' instead of 'theme-library': #437 This allowed them to still be formatted even though they are missing a .library file. However, the newly added preload exclude configuration fallback for framework libraries also requires a .library file and did not make the mentioned exception for legacy OpenUI5 theme libraries: #573 This fix adds that exception and the tests that were missing from #437
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-233