Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] replaceVersion: Also process css files #720

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Mar 10, 2022

Follow-up of #693
There are use cases for a version placeholder in *.css files.

This also adds some basic tests for placeholder replacements during
a library build.

@matz3 matz3 changed the base branch from master to next March 10, 2022 11:26
@matz3 matz3 requested a review from flovogt March 10, 2022 11:27
@matz3 matz3 changed the title next replace version placeholder test resources css [INTERNAL] replaceVersion: Also process css files Mar 10, 2022
flovogt
flovogt previously approved these changes Mar 10, 2022
Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Follow-up of #693
There are use cases for a version placeholder in *.css files.

This also adds some basic tests for placeholder replacements during
a library build.
@matz3 matz3 force-pushed the next-replace-version-placeholder-test-resources-css branch from 0998e1e to 3dda6a8 Compare March 10, 2022 14:10
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.816% when pulling 3dda6a8 on next-replace-version-placeholder-test-resources-css into daa2943 on next.

Copy link
Member

@flovogt flovogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matz3 matz3 merged commit 81c00cf into next Mar 10, 2022
@matz3 matz3 deleted the next-replace-version-placeholder-test-resources-css branch March 10, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants