Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Minifier: Support input source maps #780

Merged
merged 15 commits into from
Oct 9, 2023

Commits on Oct 2, 2023

  1. [FEATURE] Minifier: Support input source maps

    If a resource references a source map (or if we find a source map based
    on the resource name + ".map"):
    1. Use that source map for the debug variant of the resource
    2. Pass it to terser so it can update it based on the transformation,
       preserving the mapping to the initial source
    RandomByte committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    bac0783 View commit details
    Browse the repository at this point in the history
  2. [INTERNAL] Adjust comment

    matz3 authored and RandomByte committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    2b608ee View commit details
    Browse the repository at this point in the history
  3. [INTERNAL] Minifier: Do not attempt to find source maps based on modu…

    …le path
    
    We expect source maps to be referenced in the respective source
    RandomByte committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    91a2b79 View commit details
    Browse the repository at this point in the history
  4. [INTERNAL] Minifier: Ignore existing source map of resources that hav…

    …e been modified in previous tasks
    RandomByte committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    e228093 View commit details
    Browse the repository at this point in the history
  5. [INTERNAL] Minifier: Small refactoring

    * Always remove existing source map references from resource. Re-add
      reference to debug variant under certain conditions.
    * Add tests
    RandomByte committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    f674901 View commit details
    Browse the repository at this point in the history
  6. [INTERNAL] bundle/Builder: Ensure mapping of first column in index so…

    …urce map entries
    
    This solves an issue where clicking on a line of generated bundle
    content in the dev tools still openes the module located above the
    expected one. We must always ensure that the first column is mapped.
    RandomByte committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    778573b View commit details
    Browse the repository at this point in the history
  7. [INTERNAL] Fix contentModified check

    matz3 authored and RandomByte committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    94013e8 View commit details
    Browse the repository at this point in the history
  8. [INTERNAL] Add builder source maps test

    Currently only fails because default of "useInputSourceMaps" option
    of minify task is set to "false".
    matz3 authored and RandomByte committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    f7c05db View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    08699cc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a34d522 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    238f6ad View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    c713f15 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. [INTERNAL] Apply suggestions from UA review

    Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
    RandomByte and KlattG committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    390fb81 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. [INTERNAL] minify: Add unit tests

    * Move integration tests into speparate file
    * Also tag the sourcemap associated with the debug resource as
      "IsDebugVariant"
    RandomByte committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5882f97 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c45cad2 View commit details
    Browse the repository at this point in the history