Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] Throw an error on write of a resource when path does not match virBasePath of the respective adapter #453

Merged
merged 4 commits into from
Dec 16, 2022

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Dec 14, 2022

Follow-up of #448

Only perform the write operation when the path of the resource starts with the configured virtual base path of the respective adapter.

@flovogt flovogt changed the title [BREAKING] Throw an error on write of a resource when path does not match virBasePath of the respective adapter [DRAFT][BREAKING] Throw an error on write of a resource when path does not match virBasePath of the respective adapter Dec 14, 2022
@coveralls
Copy link

coveralls commented Dec 14, 2022

Coverage Status

Coverage increased (+0.04%) to 88.682% when pulling a3cc081 on throw-error-on-write-path-mismatch into 3454bc1 on main.

@flovogt flovogt changed the title [DRAFT][BREAKING] Throw an error on write of a resource when path does not match virBasePath of the respective adapter [BREAKING] Throw an error on write of a resource when path does not match virBasePath of the respective adapter Dec 15, 2022
lib/adapters/AbstractAdapter.js Outdated Show resolved Hide resolved
@flovogt flovogt merged commit d76575f into main Dec 16, 2022
@flovogt flovogt deleted the throw-error-on-write-path-mismatch branch December 16, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants