fix: diagnostic message

SAP · Apr 26, 2024 · 40e9f02 · 40e9f02
1 parent ec4fd95
commit 40e9f02
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/packages/fe/src/i18n/i18n.json b/packages/fe/src/i18n/i18n.json
@@ -24,7 +24,7 @@
   "UNKNOWN_PATH": "Unknown path: \"{{value}}\"",
   "INVALID_PROPERTY_PATH_MULTIPLE_1_TO_MANY": "Invalid property path value. Multiple 1:many association segments not allowed",
 
-  "ENTITY_SET_OR_CONTEXT_PATH_IS_MISSING_IN_MANIFEST": "EntitySet or contextPath for the current view are not defined in application manifest. Attribute value completion and diagnostics is not possible if EntitySet or contextPath are not defined or defined dynamically in controllers",
+  "ENTITY_SET_OR_CONTEXT_PATH_IS_MISSING_IN_MANIFEST": "Path cannot be identified: use absolute path or define contextPath",
   "EMPTY_CONTEXT_PATH_IN_MANIFEST": "ContextPath in manifest is empty. Attribute value completion and diagnostics are disabled",
   "RELATIVE_CONTEXT_PATH_IN_MANIFEST": "ContextPath in manifest \"{{value}}\" must be absolute. Attribute value completion and diagnostics are disabled",
   "UNKNOWN_CONTEXT_PATH_IN_MANIFEST": "Unknown contextPath in manifest \"{{value}}\". Attribute value completion and diagnostics are disabled",

diff --git a/packages/fe/src/services/diagnostics/validators/missing-entity-set.ts b/packages/fe/src/services/diagnostics/validators/missing-entity-set.ts
@@ -55,7 +55,7 @@ export function validateMissingViewEntitySet(
               start: actualAttributeValueToken.startOffset,
               end: actualAttributeValueToken.endOffset,
             },
-            severity: "info",
+            severity: "warn",
           },
         ];
       }

diff --git a/packages/fe/test/unit/services/diagnostics/validators/missing-entity-set.test.ts b/packages/fe/test/unit/services/diagnostics/validators/missing-entity-set.test.ts
@@ -76,7 +76,7 @@ describe("missing entitySet validation", () => {
         }
       );
       expect(result.map((item) => issueToSnapshot(item))).toStrictEqual([
-        "kind: MissingEntitySet; text: EntitySet or contextPath for the current view are not defined in application manifest. Attribute value completion and diagnostics is not possible if EntitySet or contextPath are not defined or defined dynamically in controllers; severity:info; offset:344-354",
+        "kind: MissingEntitySet; text: Path cannot be identified: use absolute path or define contextPath; severity:warn; offset:344-354",
       ]);
     });
 
@@ -87,7 +87,7 @@ describe("missing entitySet validation", () => {
         (c) => ({ ...c, manifestDetails: undefined } as any)
       );
       expect(result.map((item) => issueToSnapshot(item))).toStrictEqual([
-        "kind: MissingEntitySet; text: EntitySet or contextPath for the current view are not defined in application manifest. Attribute value completion and diagnostics is not possible if EntitySet or contextPath are not defined or defined dynamically in controllers; severity:info; offset:344-349",
+        "kind: MissingEntitySet; text: Path cannot be identified: use absolute path or define contextPath; severity:warn; offset:344-349",
       ]);
     });
 
@@ -103,7 +103,7 @@ describe("missing entitySet validation", () => {
         }
       );
       expect(result.map((item) => issueToSnapshot(item))).toStrictEqual([
-        "kind: MissingEntitySet; text: EntitySet or contextPath for the current view are not defined in application manifest. Attribute value completion and diagnostics is not possible if EntitySet or contextPath are not defined or defined dynamically in controllers; severity:info; offset:344-349",
+        "kind: MissingEntitySet; text: Path cannot be identified: use absolute path or define contextPath; severity:warn; offset:344-349",
       ]);
     });
   });

diff --git a/...-language-assistant/test/manual-tests/annotation_metaPath_attribute_handling.md b/...-language-assistant/test/manual-tests/annotation_metaPath_attribute_handling.md
@@ -57,7 +57,7 @@ annotate service.Travel with @(
 4. Set the metaPath attribute value as `to_Booking`. Observe warning message `Path value must end with annotation term. Use code completion to select annotation path`.
 5. Set the metaPath attribute value as `@com.sap.vocabularies.UI.v1.LineItem`. Observe warning message `Invalid annotation term: "@com.sap.vocabularies.UI.v1.LineItem". Trigger code completion to choose one of allowed annotations`.
 6. Go to app manifest file, find `routing\targets\TravelMain` settings entry and rename `entitySet` property in the nested object structure to `entitySet_`. Save the file.
-7. Set the metaPath attribute value as `@com.sap.vocabularies.UI.v1.Chart#sample1`. Observe info message `EntitySet or contextPath for the current view are not defined in application manifest. Attribute value completion and diagnostics is not possible if EntitySet or contextPath are not defined or defined dynamically in controllers`.
+7. Set the metaPath attribute value as `@com.sap.vocabularies.UI.v1.Chart#sample1`. Observe warn message `Path cannot be identified: use absolute path or define contextPath`.
 8. Revert manifest change that is done at previous step 7. Change property `entitySet` value to `Travel_`. Save the file.
 9. Set the metaPath attribute value as `@com.sap.vocabularies.UI.v1.Chart#sample`. Observe info message `Entity Set "Travel_" specified in manifest for the current view is not found. Attribute value completion and diagnostics are disabled`.
 10. Reset property `entitySet` value to `Travel` in app manifest. Save the file.