feat: tooltip on hover #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @ui5-language-assistant/language-server@1.3.0 - @ui5-language-assistant/logic-utils@1.1.2 - @ui5-language-assistant/semantic-model-types@1.2.0 - @ui5-language-assistant/semantic-model@1.2.0 - vscode-ui5-language-assistant@1.1.3 - @ui5-language-assistant/xml-views-completion@1.3.0 - @ui5-language-assistant/test-utils@1.2.0
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
| ast: XMLDocument, | ||
| offset: number, | ||
| model: UI5SemanticModel | ||
| ): BaseUI5Node | undefined { |
There was a problem hiding this comment.
We can probably be more specific than BaseUI5Node and define a "HoverUI5Node` ,e.g:
type HoverUI5Node = UI5Class | UI5Attribute | ....;
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
bd82
reviewed
May 14, 2020
| return undefined; | ||
| } | ||
|
|
||
| function findUI5ClassMemberByName( |
There was a problem hiding this comment.
This should probably go into logic-utils
There was a problem hiding this comment.
I agree but make it receive the attribute instead of its key
tal-sapan
reviewed
May 20, 2020
| UI5Enum, | ||
| BaseUI5Node, | ||
| } from "@ui5-language-assistant/semantic-model-types"; | ||
| import { getNodeDocumentation } from "./documentation"; |
There was a problem hiding this comment.
This should be the last import
tal-sapan
reviewed
May 20, 2020
tal-sapan
reviewed
May 20, 2020
| const offset = document.offsetAt(textDocumentPosition.position); | ||
| const astPosition = getAstNodeInPosition(ast, offset); | ||
| if (astPosition !== undefined) { | ||
| const ui5Node = findUI5HoverNodeAtOffset(astPosition, model); |
There was a problem hiding this comment.
Not for now but maybe we should rename findUI5HoverNodeAtOffset because to findUI5HoverNodeAtPosition
…over # Conflicts: # packages/language-server/package.json
tal-sapan
suggested changes
May 20, 2020
tal-sapan
reviewed
May 20, 2020
tal-sapan
reviewed
May 20, 2020
tal-sapan
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.