Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimization of activation processing #724

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Conversation

marufrasully
Copy link
Contributor

@marufrasully marufrasully commented Aug 19, 2024

This PR

  • activate extension only for .view.xml or .fragment.xml file
  • add provider/service to context.subscriptions - helps in clean up

This PR is cherry pick of #718

Copy link

changeset-bot bot commented Aug 19, 2024

🦋 Changeset detected

Latest commit: 5d30ba1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
vscode-ui5-language-assistant Patch
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
@ui5-language-assistant/language-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cla-assistant bot commented Aug 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@marufrasully marufrasully merged commit bfcac90 into master Aug 20, 2024
9 checks passed
@marufrasully marufrasully deleted the alex-activation branch August 20, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants