Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use latest ui5 version in case s4 placeholder #738

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

marufrasully
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 8b3bf53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@ui5-language-assistant/context Patch
vscode-ui5-language-assistant Patch
@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext Patch
@ui5-language-assistant/binding Patch
@ui5-language-assistant/fe Patch
@ui5-language-assistant/language-server Patch
@ui5-language-assistant/xml-views-completion Patch
@ui5-language-assistant/xml-views-definition Patch
@ui5-language-assistant/xml-views-quick-fix Patch
@ui5-language-assistant/xml-views-tooltip Patch
@ui5-language-assistant/xml-views-validation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@vadson71 vadson71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
De facto covered by tests, despite Sonar complaints
Didn't test locally

@marufrasully
Copy link
Contributor Author

Quality Gate Failed Quality Gate failed

Failed conditions 0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

code is secured with unit test and Sonar is wrongly reporting it.

@MN-public
Copy link
Contributor

Merging despite the sonar cloud complaints because the code is actually covered by tests as per review, see #738 (review)

@MN-public MN-public merged commit 1a974e0 into master Dec 12, 2024
9 of 10 checks passed
@MN-public MN-public deleted the fix/fallback-issue branch December 12, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants