fix: False positive for deprecated JS view/fragment type

The *.view.js / *.fragment.js file naming is just a convention but does not imply the usage of deprecated view/fragment API. As JS/TS files are checked already and usages of sap.ui.jsview / sap.ui.jsfragment are reported, there is no need to implement a separate check.
SAP · Oct 17, 2024 · 63a12e2 · 63a12e2
1 parent 9cc1202
commit 63a12e2
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 96 deletions.
diff --git a/src/linter/fileTypes/linter.ts b/src/linter/fileTypes/linter.ts
@@ -5,12 +5,8 @@ import {MESSAGE} from "../messages.js";
 const deprecatedViewFileTypes = [
 	".view.json",
 	".view.html",
-	".view.js",
 	".view.tmpl",
-	".view.ts",
 	".fragment.html",
-	".fragment.js",
-	".fragment.ts",
 ];
 
 export default async function lintFileTypes({filePathsWorkspace, context}: LinterParameters) {

diff --git a/test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedFileType.fragment.js b/test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedFileType.fragment.js
diff --git a/test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedFileType.fragment.ts b/test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedFileType.fragment.ts
diff --git a/test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedFileType.view.js b/test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedFileType.view.js
diff --git a/test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedFileType.view.ts b/test/fixtures/linter/rules/NoDeprecatedApi/NoDeprecatedFileType.view.ts
diff --git a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md
@@ -1190,52 +1190,6 @@ Generated by [AVA](https://avajs.dev).
       },
     ]
 
-## General: NoDeprecatedFileType.fragment.js
-
-> Snapshot 1
-
-    [
-      {
-        coverageInfo: [],
-        errorCount: 1,
-        fatalErrorCount: 0,
-        filePath: 'NoDeprecatedFileType.fragment.js',
-        messages: [
-          {
-            column: undefined,
-            line: undefined,
-            message: 'Use of deprecated view type \'JS\'. Use \'XML\' instead\'',
-            ruleId: 'no-deprecated-api',
-            severity: 2,
-          },
-        ],
-        warningCount: 0,
-      },
-    ]
-
-## General: NoDeprecatedFileType.fragment.ts
-
-> Snapshot 1
-
-    [
-      {
-        coverageInfo: [],
-        errorCount: 1,
-        fatalErrorCount: 0,
-        filePath: 'NoDeprecatedFileType.fragment.ts',
-        messages: [
-          {
-            column: undefined,
-            line: undefined,
-            message: 'Use of deprecated view type \'TS\'. Use \'XML\' instead\'',
-            ruleId: 'no-deprecated-api',
-            severity: 2,
-          },
-        ],
-        warningCount: 0,
-      },
-    ]
-
 ## General: NoDeprecatedFileType.view.html
 
 > Snapshot 1
@@ -1259,29 +1213,6 @@ Generated by [AVA](https://avajs.dev).
       },
     ]
 
-## General: NoDeprecatedFileType.view.js
-
-> Snapshot 1
-
-    [
-      {
-        coverageInfo: [],
-        errorCount: 1,
-        fatalErrorCount: 0,
-        filePath: 'NoDeprecatedFileType.view.js',
-        messages: [
-          {
-            column: undefined,
-            line: undefined,
-            message: 'Use of deprecated view type \'JS\'. Use \'XML\' instead\'',
-            ruleId: 'no-deprecated-api',
-            severity: 2,
-          },
-        ],
-        warningCount: 0,
-      },
-    ]
-
 ## General: NoDeprecatedFileType.view.json
 
 > Snapshot 1
@@ -1305,29 +1236,6 @@ Generated by [AVA](https://avajs.dev).
       },
     ]
 
-## General: NoDeprecatedFileType.view.ts
-
-> Snapshot 1
-
-    [
-      {
-        coverageInfo: [],
-        errorCount: 1,
-        fatalErrorCount: 0,
-        filePath: 'NoDeprecatedFileType.view.ts',
-        messages: [
-          {
-            column: undefined,
-            line: undefined,
-            message: 'Use of deprecated view type \'TS\'. Use \'XML\' instead\'',
-            ruleId: 'no-deprecated-api',
-            severity: 2,
-          },
-        ],
-        warningCount: 0,
-      },
-    ]
-
 ## General: PartialDeprecation.js
 
 > Snapshot 1

diff --git a/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap b/test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap