Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive when using data-sap-ui-on-init with the name of a global function (v1.0.0) #336

Closed
codeworrior opened this issue Oct 1, 2024 · 1 comment
Closed

False positive when using data-sap-ui-on-init with the name of a global function (v1.0.0) #336

codeworrior opened this issue Oct 1, 2024 · 1 comment
Assignees
@RandomByte
Labels
bug Something isn't working

Comments

@codeworrior
Copy link
Member

Expected Behavior

When I use data-sap-ui-on-init with the name of a global function, this is still a valid and supported use case and should not result in a UI5 linter finding.

Current Behavior

When I lint sap.ui.core (main branch), I get a finding for this usage of data-sap-ui-on-init.

Context

  • UI5 linter version: 1.0.0

Log Output / Stack Trace

12:26: Use of deprecated value 'fninit' for bootstrap parameter 'data-sap-ui-on-init
@codeworrior codeworrior added the bug Something isn't working label Oct 1, 2024
@RandomByte RandomByte self-assigned this Oct 1, 2024
RandomByte added a commit that referenced this issue Oct 1, 2024
@RandomByte
fix(html): False positive for global function name in on-init bootstr…
1227b8b 
…ap param

Resolves #336
@codeworrior
Copy link
Member Author

Thank you for the quick fix!

maxreichmann pushed a commit that referenced this issue Oct 2, 2024
@RandomByte @maxreichmann
fix(html): False positive for global function name in on-init bootstr…
e3edd5e 
…ap param

Resolves #336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RandomByte RandomByte

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RandomByte @codeworrior