Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update texts + test samples & the respective test snapshots #344

Merged
merged 3 commits into from
Oct 2, 2024
Merged

fix: Update texts + test samples & the respective test snapshots #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ff4ebc
fix: Typo in test + update snapshots for it
d3xter666 Oct 2, 2024
ddaec6f
refactor: Update messages + respective test snapshots
d3xter666 Oct 2, 2024
3c5b414
fix: Resolve merge conflicts
d3xter666 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/linter/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export const MESSAGE_INFO = {
severity: LintMessageSeverity.Error,
ruleId: RULES["no-deprecated-api"],

message: () => `DeclarativeSupport is deprecated.`,
message: () => `DeclarativeSupport is deprecated`,
details: () =>
`Please consider using {@link sap.ui.core.mvc.XMLView XMLViews} or` +
` {@link topic:e6bb33d076dc4f23be50c082c271b9f0 Typed Views} instead. For more information,` +
Expand All @@ -173,7 +173,7 @@ export const MESSAGE_INFO = {
severity: LintMessageSeverity.Error,
ruleId: RULES["no-deprecated-api"],

message: () => `LessSupport is deprecated.`,
message: () => `LessSupport is deprecated`,
details: () =>
"Please consider using UI5 Tooling https://sap.github.io/ui5-tooling/stable/ to compile LESS to CSS on the fly.",
},
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/linter/rules/NoDeprecatedApi/BootstrapParameters_Deprecations3.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
data-sap-ui-theme="sap_horizon"
data-sap-ui-libs="sap.m"
data-sap-ui-async="true"
data-sap-ui-on-init="modules:sap/ui/core/plugin/DeclarativeSupport"
data-sap-ui-on-init="module:sap/ui/core/plugin/DeclarativeSupport"
>
</script>
</head>
Expand Down
16 changes: 4 additions & 12 deletions test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,15 @@ Generated by [AVA](https://avajs.dev).
{
column: 24,
line: 11,
message: 'DeclarativeSupport is deprecated.',
message: 'DeclarativeSupport is deprecated',
messageDetails: 'Please consider using XMLViews (https://ui5.sap.com/1.120/#/api/sap.ui.core.mvc.XMLView) or Typed Views (https://ui5.sap.com/#/topic/e6bb33d076dc4f23be50c082c271b9f0) instead. For more information, see the documentation on View types (https://ui5.sap.com/#/topic/91f27e3e6f4d1014b6dd926db0e91070).',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 24,
line: 11,
message: 'LessSupport is deprecated.',
message: 'LessSupport is deprecated',
messageDetails: 'Please consider using UI5 Tooling https://sap.github.io/ui5-tooling/stable/ to compile LESS to CSS on the fly.',
ruleId: 'no-deprecated-api',
severity: 2,
Expand All @@ -112,22 +112,14 @@ Generated by [AVA](https://avajs.dev).
[
{
coverageInfo: [],
errorCount: 3,
errorCount: 2,
fatalErrorCount: 0,
filePath: 'BootstrapParameters_Deprecations3.html',
messages: [
{
column: 24,
line: 11,
message: 'Use of deprecated value \'modules:sap/ui/core/plugin/declarativesupport\' for bootstrap parameter \'data-sap-ui-on-init\'',
messageDetails: 'Configuration Options and URL Parameters (https://ui5.sap.com/#/topic/91f2d03b6f4d1014b6dd926db0e91070)',
ruleId: 'no-deprecated-api',
severity: 2,
},
{
column: 24,
line: 11,
message: 'DeclarativeSupport is deprecated.',
message: 'DeclarativeSupport is deprecated',
messageDetails: 'Please consider using XMLViews (https://ui5.sap.com/1.120/#/api/sap.ui.core.mvc.XMLView) or Typed Views (https://ui5.sap.com/#/topic/e6bb33d076dc4f23be50c082c271b9f0) instead. For more information, see the documentation on View types (https://ui5.sap.com/#/topic/91f27e3e6f4d1014b6dd926db0e91070).',
ruleId: 'no-deprecated-api',
severity: 2,
Expand Down
Binary file modified test/lib/linter/rules/snapshots/NoDeprecatedApi.ts.snap
View file
Open in desktop
Binary file not shown.