Review feedback

SAP · May 5, 2020 · 7922f62 · 7922f62
1 parent b4104d1
commit 7922f62
Showing 1 changed file with 20 additions and 20 deletions.
diff --git a/test/lib/validation/schema/__helper__/extension.js b/test/lib/validation/schema/__helper__/extension.js
@@ -22,7 +22,6 @@ module.exports = {
  test(`kind: extension / type: ${type} basic (${specVersion})`, async (t) => {
  await assertValidation(t, Object.assign({
  "specVersion": specVersion,
- "kind": "extension",
  "type": type,
  "metadata": {
  "name": "my-" + type
@@ -33,7 +32,6 @@ module.exports = {
  test(`kind: extension / type: ${type} additionalProperties (${specVersion})`, async (t) => {
  await assertValidation(t, Object.assign({
  "specVersion": specVersion,
- "kind": "extension",
  "type": type,
  "metadata": {
  "name": "my-" + type
@@ -50,24 +48,26 @@ module.exports = {
  }]);
  });
 
- test(`${type} Invalid configuration: Additional property (${specVersion})`, async (t) => {
- await assertValidation(t, Object.assign( {
- "specVersion": specVersion,
- "type": type,
- "metadata": {
- "name": "my-" + type
- },
- "notAllowed": true
- }, additionalConfiguration), [{
- dataPath: "",
- keyword: "additionalProperties",
- message: "should NOT have additional properties",
- params: {
- additionalProperty: "notAllowed",
- },
- schemaPath: specVersion === "2.1" ? "#/then/additionalProperties" : "#/else/additionalProperties"
- }]);
- });
+ test(`kind: extension / type: ${type} Invalid configuration: Additional property (${specVersion})`,
+ async (t) => {
+ await assertValidation(t, Object.assign( {
+ "specVersion": specVersion,
+ "type": type,
+ "metadata": {
+ "name": "my-" + type
+ },
+ "notAllowed": true
+ }, additionalConfiguration), [{
+ dataPath: "",
+ keyword: "additionalProperties",
+ message: "should NOT have additional properties",
+ params: {
+ additionalProperty: "notAllowed",
+ },
+ schemaPath:
+ specVersion === "2.1" ? "#/then/additionalProperties" : "#/else/additionalProperties"
+ }]);
+ });
  });
  }
 };