[INTERNAL] Apply feedback from code review

SAP · May 4, 2023 · 9f0072b · 9f0072b
1 parent 00a6b09
commit 9f0072b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/lib/graph/graph.js b/lib/graph/graph.js
@@ -96,7 +96,7 @@ export async function graphFromPackageDependencies({
  *		<code>cwd</code> or an absolute path. In both case, platform-specific path segment separators must be used.
  * @param {string} [options.versionOverride] Framework version to use instead of the one defined in the root project
  * @param {module:@ui5/project/ui5Framework/maven/CacheMode} [options.cacheMode]
- *      Cache mode to use when consuming SNAPSHOT versions
+ *      Cache mode to use when consuming SNAPSHOT versions of a framework
  * @param {string} [options.resolveFrameworkDependencies=true]
  *		Whether framework dependencies should be added to the graph
  * @returns {Promise<@ui5/project/graph/ProjectGraph>} Promise resolving to a Project Graph instance
@@ -148,7 +148,7 @@ export async function graphFromStaticFile({
  *		<code>cwd</code> or an absolute path. In both case, platform-specific path segment separators must be used.
  * @param {string} [options.versionOverride] Framework version to use instead of the one defined in the root project
  * @param {module:@ui5/project/ui5Framework/maven/CacheMode} [options.cacheMode]
- *      Cache mode to use when consuming SNAPSHOT versions
+ *      Cache mode to use when consuming SNAPSHOT versions of a framework
  * @param {string} [options.resolveFrameworkDependencies=true]
  *		Whether framework dependencies should be added to the graph
  * @returns {Promise<@ui5/project/graph/ProjectGraph>} Promise resolving to a Project Graph instance

diff --git a/lib/graph/helpers/ui5Framework.js b/lib/graph/helpers/ui5Framework.js
@@ -281,7 +281,7 @@ export default {
 	 * @param {string} [options.versionOverride] Framework version to use instead of the root projects framework
 	 *   version
 	 * @param {module:@ui5/project/ui5Framework/maven/CacheMode} [options.cacheMode]
- 	 *   Cache mode to use when consuming SNAPSHOT versions
+ 	 *   Cache mode to use when consuming SNAPSHOT versions of a framework
 	 * @param {@ui5/project/graph/Workspace} [options.workspace]
 	 *   Optional workspace instance to use for overriding node resolutions
 	 * @returns {Promise<@ui5/project/graph/ProjectGraph>}

diff --git a/test/lib/graph/helpers/ui5Framework.js b/test/lib/graph/helpers/ui5Framework.js
@@ -179,7 +179,6 @@ test.serial("enrichProjectGraph: without framework configuration", async (t) =>
 
 test.serial("enrichProjectGraph SNAPSHOT", async (t) => {
 	const {sinon, ui5Framework, utils, Sapui5MavenSnapshotResolverInstallStub} = t.context;
-	process.env.UI5_MAVEN_SNAPSHOT_ENDPOINT_URL = "__url__";
 
 	const dependencyTree = {
 		id: "test1",
@@ -266,8 +265,6 @@ test.serial("enrichProjectGraph SNAPSHOT", async (t) => {
 	t.deepEqual(callbackCalls, [
 		"application.a"
 	], "Traversed graph in correct order");
-
-	delete process.env.UI5_MAVEN_SNAPSHOT_ENDPOINT_URL;
 });
 
 test.serial("enrichProjectGraph: With versionOverride", async (t) => {