[FEATURE] projectPreprocessor: Log warning when using a deprecated or restricted dependency #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… restricted dependency Projects in the tree that are not the root project may trigger a warning log if they configure any of the following metadata flags: - deprecated: true - sapInternal: true The latter may not trigger a warning if its parent project defines a metadata flag "allowSapInternal: true".
RandomByte
force-pushed
the
deprecated-internal-warnings
branch
from
efcd106
to
b15aae3
Compare
RandomByte
changed the title
matz3
reviewed
Mar 6, 2020
test/lib/projectPreprocessor.js
Outdated
| t.deepEqual(logWarnSpy.getCall(0).args[0], | ||
| "Dependency my.project is deprecated and should not be used for new projects!", | ||
| "Logged expected warning message"); | ||
| mock.stop("@ui5/logger"); |
There was a problem hiding this comment.
You might also use mock.stopAll() within test.afterEach.always to ensure a proper cleanup
matz3
approved these changes
Mar 9, 2020
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects in the tree that are not the root project may trigger a warning
log if they configure any of the following metadata flags:
The latter may not trigger a warning if its parent project defines a
metadata flag "allowSapInternal: true".