Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] specVersion 2.3 #388

Merged
merged 2 commits into from
Feb 9, 2021
Merged

[FEATURE] specVersion 2.3 #388

merged 2 commits into from
Feb 9, 2021

Conversation

matz3
Copy link
Member

@matz3 matz3 commented Jan 25, 2021 •
edited
Loading

  • Adds libraryPreload/componentPreload excludes configuration

JIRA: CPOUI5FOUNDATION-233

@matz3
[FEATURE] specVersion 2.3
e66337d 
- Adds libraryPreload/componentPreload excludes configuration
@matz3 matz3 requested a review from RandomByte January 25, 2021 16:00
@coveralls
Copy link

coveralls commented Jan 25, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 91.43% when pulling 4374061 on schema-specVersion-2.3 into aca27e0 on master.

RandomByte
RandomByte approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But should only be merged after SAP/ui5-builder#573 has been merged

@matz3 matz3 merged commit 3e28026 into master Feb 9, 2021
@matz3 matz3 deleted the schema-specVersion-2.3 branch February 9, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matz3 @coveralls @RandomByte