Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] manifest.json: Auto-fill supportedLocales #683

Merged
merged 3 commits into from
Jul 12, 2024
Merged

[FEATURE] manifest.json: Auto-fill supportedLocales #683

merged 3 commits into from
Jul 12, 2024

Conversation

flovogt
Copy link
Member

@flovogt flovogt commented Nov 20, 2023 •
edited
Loading

@coveralls
Copy link

coveralls commented Nov 20, 2023 •
edited
Loading

Coverage Status

coverage: 95.717% (+0.002%) from 95.715%
when pulling 0a7f7f6 on manifest-transformer
into 47964c3 on main.

@flovogt flovogt force-pushed the manifest-transformer branch 2 times, most recently from 26f5676 to bb906b2 Compare December 12, 2023 14:48
@flovogt flovogt marked this pull request as ready for review January 8, 2024 11:32
This was referenced Jan 8, 2024
Merged
Merged
Closed
@flovogt flovogt requested a review from a team January 22, 2024 10:08
d3xter666
d3xter666 previously approved these changes Jan 23, 2024
View reviewed changes
@flovogt flovogt force-pushed the manifest-transformer branch 2 times, most recently from 7b631fd to 9c50cad Compare March 28, 2024 15:27
@flovogt flovogt added the blocked Pull requests that are blocked label Mar 28, 2024
@flovogt
Copy link
Member Author

flovogt commented Mar 28, 2024

Submit this PR together with other feature related PRs.

matz3
matz3 reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flovogt flovogt merged commit c905d4f into main Jul 12, 2024
17 checks passed
@flovogt flovogt deleted the manifest-transformer branch July 12, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 left review comments

@RandomByte RandomByte RandomByte approved these changes

@d3xter666 d3xter666 d3xter666 left review comments

Assignees
No one assigned
Labels
blocked Pull requests that are blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flovogt @coveralls @matz3 @RandomByte @d3xter666