[FEATURE] manifest.json: Auto-fill supportedLocales #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovogt
force-pushed
the
manifest-transformer
branch
from
a6e4365
to
1e8e203
Compare
flovogt
force-pushed
the
manifest-transformer
branch
from
1e8e203
to
309ccc7
Compare
flovogt
force-pushed
the
manifest-transformer
branch
2 times, most recently
from
d6907ba
to
2790970
Compare
This was referenced Jan 8, 2024
d3xter666
previously approved these changes
Jan 23, 2024
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
d3xter666
reviewed
Jan 24, 2024
matz3
reviewed
Jan 31, 2024
lib/middleware/serveResources.js
Outdated
| if (rManifest.test(resourcePath)) { | ||
| // Special handling for manifest.json file by adding additional content to the served manifest.json | ||
| const {default: manifestEnricher} = await import("@ui5/builder/processors/manifestEnricher"); | ||
| await manifestEnricher({ |
There was a problem hiding this comment.
The processor modifies the resource (via setString), which can cause some inconsistent behaviour during development regarding caching, so we might need to disable etag caching for manifest.json. I need to check this again to understand when it exactly happens..
RandomByte
requested changes
Jan 31, 2024
matz3
force-pushed
the
manifest-transformer
branch
from
f3bd5eb
to
ebaad4d
Compare
flovogt
force-pushed
the
manifest-transformer
branch
3 times, most recently
from
4883586
to
3d426cc
Compare
flovogt
force-pushed
the
manifest-transformer
branch
from
3d426cc
to
f9b4585
Compare
flovogt
force-pushed
the
manifest-transformer
branch
from
f9b4585
to
b1a688c
Compare
matz3
force-pushed
the
manifest-transformer
branch
from
b1a688c
to
08a3c28
Compare
flovogt
force-pushed
the
manifest-transformer
branch
3 times, most recently
from
ac1bb85
to
afc2fde
Compare
flovogt
force-pushed
the
manifest-transformer
branch
2 times, most recently
from
5808b24
to
f8621a3
Compare
JIRA: CPOUI5FOUNDATION-296
flovogt
force-pushed
the
manifest-transformer
branch
from
f8621a3
to
ba62e4d
Compare
RandomByte
approved these changes
Jul 9, 2024
flovogt
added a commit
to SAP/ui5-project
that referenced
this pull request
Jul 12, 2024
JIRA: CPOUI5FOUNDATION-296 Depends on: - SAP/ui5-builder#957 - SAP/ui5-server#617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-296
Depends on: