[INTERNAL] ui5-workspace.yaml schema #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it supports names for additional schemes Update tests
matz3
requested changes
Jan 13, 2023
Every validator is a new schema type and a single validator instance cannot validate multiple schemas
matz3
previously requested changes
Jan 16, 2023
d3xter666
changed the title
RandomByte
requested changes
Jan 18, 2023
RandomByte
reviewed
Jan 18, 2023
RandomByte
requested changes
Jan 19, 2023
RandomByte
approved these changes
Jan 23, 2023
d3xter666
dismissed
matz3’s stale review
Merlin also reviewed it and checked against his workspace pull request
d3xter666
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Jan 24, 2023
JIRA: CPOUI5FOUNDATION-584 Generate ui5-workspace.yaml schema that complies with the [local dependency resolution spec](https://github.com/SAP/ui5-tooling/blob/rfc-local-dependency-resolution/rfcs/0006-local-dependency-resolution.md#workspace-configuration-file) For further details, check the [RFC 0006 Local Dependency Resolution](https://github.com/SAP/ui5-tooling/blob/rfc-local-dependency-resolution/rfcs/0006-local-dependency-resolution.md) This change depends on SAP/ui5-project#543
matz3
reviewed
Feb 6, 2023
d3xter666
added a commit
that referenced
this pull request
Feb 7, 2023
JIRA: CPOUI5FOUNDATION-584 Provide ui5-workspace.yaml schema that complies with the [local dependency resolution spec](https://github.com/SAP/ui5-tooling/blob/rfc-local-dependency-resolution/rfcs/0006-local-dependency-resolution.md#workspace-configuration-file) For further details, check the [RFC 0006 Local Dependency Resolution](https://github.com/SAP/ui5-tooling/blob/rfc-local-dependency-resolution/rfcs/0006-local-dependency-resolution.md)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-584
Provide ui5-workspace.yaml schema that complies with the local dependency resolution spec
For further details, check the RFC 0006 Local Dependency Resolution