[BREAKING] Schema: Restrict metadata.name for specVersion >= 3.0 #552
+1,025
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
spec-name-validation
branch
2 times, most recently
from
dc760ae
to
44edda5
Compare
RandomByte
force-pushed
the
spec-name-validation
branch
from
44edda5
to
7264094
Compare
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Jan 24, 2023
d3xter666
reviewed
Jan 25, 2023
d3xter666
reviewed
Jan 25, 2023
As proposed in chapter 6 of RFC0012([1]), restrict the 'name' property for
projects and extensions defining specification version 3.0 and later.
BREAKING CHANGE:
For projects and extensions defining specVersion 3.0 and later, the
metadata.name property must satisfy the following conditions:
* Must be at least 3 characters long
* Must be no longer than 50 characters
* Must contain lowercase characters only
* Must contain alphanumeric characters, dash, underscore and period only
- Exception: `@` and `/` are allowed at certain positions as
explained below
* Must start with an alphabetic character or an `@`-character
* If a name starts with an `@`-character, it must contain exactly one
forward-slash `/`
- This is aligned with the npm concept for package scopes
- e.g. `@org/lib.name`
For details, please see refer to chapter 6 of RFC0012([1]).
[1]: SAP/ui5-tooling#664
Specification Versions <3.0 should allow any names
RandomByte
force-pushed
the
spec-name-validation
branch
from
7264094
to
e573adf
Compare
Also escape forward slash just to be sure
RandomByte
force-pushed
the
spec-name-validation
branch
from
e573adf
to
45f2871
Compare
d3xter666
approved these changes
Jan 25, 2023
RandomByte
added a commit
that referenced
this pull request
Jan 25, 2023
Apply the same rules as for project and extension names. Also see #552 Also update links to future Workspace configuration page.
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Jan 25, 2023
RandomByte
added a commit
that referenced
this pull request
Jan 27, 2023
Apply the same rules as for project and extension names. Also see #552 Also update links to future Workspace configuration page.
RandomByte
added a commit
to SAP/ui5-tooling
that referenced
this pull request
Feb 2, 2023
d3xter666
pushed a commit
that referenced
this pull request
Feb 7, 2023
As proposed in chapter 6 of RFC0012([1]), restrict the 'name' property for
projects and extensions defining specification version 3.0 and later.
BREAKING CHANGE:
For projects and extensions defining specVersion 3.0 and later, the
metadata.name property must satisfy the following conditions:
* Must be at least 3 characters long
* Must be no longer than 50 characters
* Must contain lowercase characters only
* Must contain alphanumeric characters, dash, underscore and period only
- Exception: `@` and `/` are allowed at certain positions as
explained below
* Must start with an alphabetic character or an `@`-character
* If a name starts with an `@`-character, it must contain exactly one
forward-slash `/`
- This is aligned with the npm concept for package scopes
- e.g. `@org/lib.name`
For details, please see refer to chapter 6 of RFC0012([1]).
[1]: SAP/ui5-tooling#664
d3xter666
pushed a commit
that referenced
this pull request
Feb 7, 2023
Apply the same rules as for project and extension names. Also see #552 Also update links to future Workspace configuration page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in chapter 6 of RFC0012(1), restrict the 'name' property for
projects and extensions defining specification version 3.0 and later.
BREAKING CHANGE:
For projects and extensions defining specVersion 3.0 and later, the
metadata.name property must satisfy the following conditions:
@and/are allowed at certain positions asexplained below
@-character@-character, it must contain exactly oneforward-slash
/@org/lib.nameFor details, please see refer to chapter 6 of RFC0012(1).