[FEATURE] Enable snapshot consumption from Maven repository #570
Conversation
d3xter666
changed the title
d3xter666
changed the title
d3xter666
changed the title
|
Hi @KlattG, I updated some user-facing texts and would appreciate your feedback. Here's the delta: |
| ui5HomeDir: path.resolve( | ||
| ui5HomeDir || path.join(os.homedir(), ".ui5") | ||
| ), | ||
| snapshotEndpointUrlCb: this._snapshotEndpointUrlCb, |
There was a problem hiding this comment.
Since this method is static, this._snapshotEndpointUrlCb is undefined and needs to be provided as a parameter.
I noticed this only in a manual test locally. I'll add a commit fixing this
…nfirmation if stdout is non-interactive
…ed skipConfirmation parameter
| @@ -208,6 +208,13 @@ class Sapui5MavenSnapshotResolver extends AbstractResolver { | |||
| } | |||
| } | |||
|
|
|||
| if (!process.stdout.isTTY) { | |||
| // Do not prompt if stdout is non-interactive (i.e. in CI environments) and just use the URL | |||
There was a problem hiding this comment.
Isn't this against the idea to first ask for confirmation to use the URL?
There was a problem hiding this comment.
Yeah, I was asking myself that too. Since we can't ask the user in this case, we need to decide upfront.
I went with using the Maven config since I expect this to make things easier in CI environments where the config is already present (I know of some base images where this is the case). But you're right, it might be unwanted or unexpected.
However, the only alternative I see is to always ignore the Maven configuration in CI environments, forcing users to configure the environment variable or ui5 config.
…ame function, do not resolve if sdtout is non-interactive
…s module This caused the creation of an empty directory structure for the tests
Introduce a new Configuration module for persisting UI5 Project specific settings. Complements: #570 JIRA: CPOUI5FOUNDATION-634 Co-authored-by: Yavor Ivanov <yavor.ivanov@sap.com>
This feature depends on SAP/ui5-project#575 and makes the configuration of the `mavenSnapshotEndpointUrl` option possible, which is used by SAP/ui5-project#570 Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com> Co-authored-by: Günter Klatt <57760635+KlattG@users.noreply.github.com>
This is just a rebase withmainof Enable snapshot consumption from Maven repository #569. The original change had conflicts with the workspace implementation.Implementation of snapshot consumption from Maven repository. This is the final implementation and is the continuation work from the base change: #478
The change also implements the RFC for a ConfigurationThe configuration part has been moved into a separate change: #575
JIRA: CPOUI5FOUNDATION-581