[POC] ProjectBuilder: Build projects concurrently if possible #626
+89
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the required dependencies information provided by the tasks, determine which projects need to be build in sequence and which can be build in parallel. This can lead to a significantly faster build in some cases, depending on the number of dependencies and which tasks need to be executed.
RandomByte
changed the title
With this change the build order is no longer pre-determined but dynamic. Once all dependencies of a project (as defined by the task runner) are built, the project is built. Renamed env variable UI5_BUILD_PARALLEL to UI5_BUILD_CONCURRENT
flovogt
reviewed
Jun 26, 2023
| @@ -121,6 +121,7 @@ class ProjectBuilder { | |||
| * @param {object} parameters Parameters | |||
| * @param {string} parameters.destPath Target path | |||
| * @param {boolean} [parameters.cleanDest=false] Decides whether project should clean the target path before build | |||
| * @param {boolean} [parameters.concurrentBuild=false] Whether to build projects concurrently if possible | |||
There was a problem hiding this comment.
todo: we should document well what it means "if possible"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the required dependencies information provided by the tasks, determine which projects need to be build in sequence and which can be build in parallel.
This can lead to a significantly faster build in some cases, depending on the number of dependencies and which tasks need to be executed. A major drawback is currently that it becomes unclear which log messages are related to which project.
Benchmarks
Based on 1f5293f
openui5-sample-app (
6240774)ui5 build -aUI5_BUILD_CONCURRENT=X ui5 build -aAbout 60 UI5 Framework Libraries (full build)
ui5 build -aUI5_BUILD_CONCURRENT=X ui5 build -aAbout 60 UI5 Framework Libraries (reduced build)
Only executing tasks
generateLibraryPreload,generateBundle,generateComponentPreload,generateLibraryManifestandminify.ui5 build -a --exclude-task "*" --include-task generateLibraryPreload generateBundle generateComponentPreload generateLibraryManifest minifyUI5_BUILD_CONCURRENT=X ui5 build -a --exclude-task "*" --include-task generateLibraryPreload generateBundle generateComponentPreload generateLibraryManifest minify