-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Allow usage of after/before task assignment for all standard tasks #628
Merged
Commits on Sep 5, 2023
-
[FIX] Allow usage of after/before task assignment of generateBundle
When migrating an project from V2 to V3 the after/before task assignments of custom tasks often has to be adjusted because the task `uglify` got removed and new `minify` task is executed earlier as the `uglify` task. In the migration guide we have written that we can not make any assumptions about the task which should be used as the new "last" task executed by the standard UI5 Tooling build tasks. See https://sap.github.io/ui5-tooling/stable/updates/migrate-v3/#removal-of-standard-tasks-and-processors. In the above mentioned documentation we have a list with all tasks and the execution order. Currently, it works to assign a custom task after/before a task which is not executed at all. So you can assign a custom task to `afterTask: generateVersionInfo` although the task `generateVersionInfo` is not executed. This works for every standard UI5 Tooling build task except for `generateBundle`. This PR aligns the behaviour also for the `generateBundle` task. JIRA: CPOUI5FOUNDATION-724
Configuration menu - View commit details
-
Copy full SHA for 4962e9e - Browse repository at this point
Copy the full SHA 4962e9eView commit details
Commits on Sep 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3a7fc57 - Browse repository at this point
Copy the full SHA 3a7fc57View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf98ea2 - Browse repository at this point
Copy the full SHA bf98ea2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0600449 - Browse repository at this point
Copy the full SHA 0600449View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77b491e - Browse repository at this point
Copy the full SHA 77b491eView commit details
Commits on Sep 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c215902 - Browse repository at this point
Copy the full SHA c215902View commit details -
Configuration menu - View commit details
-
Copy full SHA for eab202b - Browse repository at this point
Copy the full SHA eab202bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2986757 - Browse repository at this point
Copy the full SHA 2986757View commit details
Commits on Sep 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4053bdd - Browse repository at this point
Copy the full SHA 4053bddView commit details
Commits on Sep 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 616f420 - Browse repository at this point
Copy the full SHA 616f420View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.