Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Allow usage of after/before task assignment for all standard tasks #628

Merged
merged 10 commits into from
Sep 27, 2023

Commits on Sep 5, 2023

  1. [FIX] Allow usage of after/before task assignment of generateBundle

    When migrating an project from V2 to V3 the after/before task
    assignments of custom tasks often has to be adjusted because the task
    `uglify` got removed and new `minify` task is executed earlier as the
    `uglify` task.
    
    In the migration guide we have written that we can not make any
    assumptions about the task which should be used as the new "last" task
    executed by the standard UI5 Tooling build tasks.
    See https://sap.github.io/ui5-tooling/stable/updates/migrate-v3/#removal-of-standard-tasks-and-processors.
    
    In the above mentioned documentation we have a list with all tasks and
    the execution order.
    Currently, it works to assign a custom task after/before a task which
    is not executed at all.
    So you can assign a custom task to `afterTask: generateVersionInfo`
    although the task `generateVersionInfo` is not executed.
    
    This works for every standard UI5 Tooling build task except for
    `generateBundle`.
    This PR aligns the behaviour also for the `generateBundle` task.
    
    JIRA: CPOUI5FOUNDATION-724
    flovogt authored and matz3 committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    4962e9e View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. Adjust library.js

    d3xter666 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    3a7fc57 View commit details
    Browse the repository at this point in the history
  2. Adjust themeLibrary.js

    d3xter666 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    bf98ea2 View commit details
    Browse the repository at this point in the history
  3. Fix & improve tests

    d3xter666 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    0600449 View commit details
    Browse the repository at this point in the history
  4. Enhance themeLibrary tests

    d3xter666 committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    77b491e View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    c215902 View commit details
    Browse the repository at this point in the history
  2. Change test name

    d3xter666 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    eab202b View commit details
    Browse the repository at this point in the history
  3. Fix eslint issues

    d3xter666 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2986757 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Configuration menu
    Copy the full SHA
    4053bdd View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Configuration menu
    Copy the full SHA
    616f420 View commit details
    Browse the repository at this point in the history