Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Apply specVersion defaults from ui5.yaml.json schema #733

Merged
merged 16 commits into from
Jul 2, 2024

Conversation

d3xter666
Copy link
Contributor

JIRA: CPOUI5FOUNDATION-835

@d3xter666 d3xter666 marked this pull request as draft June 13, 2024 11:46
@coveralls
Copy link

Coverage Status

coverage: 95.736% (+0.02%) from 95.719%
when pulling 957f3ea on apply-spec-defaults
into f33bd8e on main.

@coveralls
Copy link

Coverage Status

coverage: 95.738% (+0.02%) from 95.719%
when pulling 3a07015 on apply-spec-defaults
into f33bd8e on main.

@coveralls
Copy link

Coverage Status

coverage: 95.738% (+0.02%) from 95.719%
when pulling b8605d9 on apply-spec-defaults
into f33bd8e on main.

@d3xter666 d3xter666 marked this pull request as ready for review June 13, 2024 15:15
@d3xter666 d3xter666 requested a review from a team June 13, 2024 15:15
@d3xter666 d3xter666 requested a review from KlattG June 24, 2024 14:13
@d3xter666
Copy link
Contributor Author

Hi @KlattG,

Would you take a look at this one, please?

Cheers

Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions, otherwise LGTM

lib/validation/validator.js Outdated Show resolved Hide resolved
lib/validation/validator.js Outdated Show resolved Hide resolved
lib/validation/validator.js Outdated Show resolved Hide resolved
@d3xter666 d3xter666 requested a review from KlattG June 25, 2024 07:44
@coveralls
Copy link

Coverage Status

coverage: 95.738% (+0.02%) from 95.719%
when pulling 1f7e58e on apply-spec-defaults
into f33bd8e on main.

@coveralls
Copy link

Coverage Status

coverage: 95.738% (+0.02%) from 95.719%
when pulling 1f7e58e on apply-spec-defaults
into f33bd8e on main.

@coveralls
Copy link

Coverage Status

coverage: 95.738% (+0.02%) from 95.719%
when pulling 1f7e58e on apply-spec-defaults
into f33bd8e on main.

Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

coverage: 95.739% (+0.02%) from 95.719%
when pulling e6a9e0b on apply-spec-defaults
into f33bd8e on main.

@coveralls
Copy link

Coverage Status

coverage: 95.715% (-0.004%) from 95.719%
when pulling a1bce2f on apply-spec-defaults
into f33bd8e on main.

@coveralls
Copy link

Coverage Status

coverage: 95.715% (-0.004%) from 95.719%
when pulling 02ef905 on apply-spec-defaults
into f33bd8e on main.

lib/validation/validator.js Outdated Show resolved Hide resolved
@matz3 matz3 requested a review from a team June 28, 2024 12:58
lib/validation/validator.js Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 95.715% (-0.004%) from 95.719%
when pulling eebd770 on apply-spec-defaults
into f33bd8e on main.

@coveralls
Copy link

Coverage Status

coverage: 95.715% (-0.004%) from 95.719%
when pulling 7e05687 on apply-spec-defaults
into e06c62a on main.

Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d3xter666 d3xter666 merged commit e3e8f85 into main Jul 2, 2024
17 checks passed
@d3xter666 d3xter666 deleted the apply-spec-defaults branch July 2, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants