Sanitize properly jQuery object when building

SAP · Nov 23, 2023 · 924188b · 924188b
1 parent 7f501a8
commit 924188b
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/middleware/testRunner/testrunner.html b/lib/middleware/testRunner/testrunner.html
@@ -23,7 +23,7 @@
 	</script>
 
 	<script>
-	jQuery.fn.filterByText = function(textbox) {
+	jQuery.fn.filterByText = function($textbox) {
 		return this.each(function() {
 			var selectbox = this;
 			var options = [];
@@ -32,7 +32,10 @@
 			});
 			jQuery(selectbox).data("options", options);
 
-			jQuery(textbox).on("change keyup", function() {
+			// jQuery object or a selector
+			// (https://codeql.github.com/codeql-query-help/javascript/js-unsafe-jquery-plugin/)
+			$textbox = ($textbox instanceof jQuery) ? $textbox : jQuery(jQuery.find($textbox));
+			$textbox.on("change keyup", function() {
 				var options = jQuery(selectbox).empty().data("options");
 				var search = jQuery(this).val().trim();
 				var regex = new RegExp(search, "gi");