[FEATURE] Properties File Escaping #214
Conversation
|
|
In order to make the tests work @ui5/builder#293 needs to be linked into the project. |
There was a problem hiding this comment.
Fine with me. We need to wait for the release of SAP/ui5-builder#293 and then rebase this PR to have the tests pass
serveResources uses stringEscaper to escape .properties files.
Default is "ISO-8859-1"
propertiesFileEncoding -> propertiesSourceFileEncoding
propertiesSourceFileEncoding -> propertiesFileSourceEncoding
No special logic for properties files regarding charset and type.
Fix test messages in main.js
The resource is drained because it is piped in the serveResources middleware. Therefore the getStream and pipe functionality is stubbed. Such that its content can be compared in the test.
tobiasso85
force-pushed
the
properties-file-escaping
branch
from
e0d424f
to
62dd62f
Compare
|
Please squash and merge! |
| type = mime.lookup(resourcePath) || "application/octet-stream"; | ||
| // Special handling for *.properties files escape non ascii characters. | ||
| const nonAsciiEscaper = require("@ui5/builder").processors.nonAsciiEscaper; | ||
| const propertiesFileSourceEncoding = project && project.resources && project.resources.configuration && project.resources.configuration.propertiesFileSourceEncoding; |
There was a problem hiding this comment.
I think we missed something here 🤔
project is the root project. However, resources are taken from resources.all. So we rather need to look for the project on the resource. Just like we do in the lbt Bundler
We also need to add a test for this: A dependency tree of two projects, one with UTF-8 encoding and another one with ISO-8859-1, making sure that both are being processed correctly (stubs should be sufficient, no actual comparison of the results)
There was a problem hiding this comment.
Should be resolved with: #219
serveResources uses stringEscaper to escape .properties files.
Builds on @ui5/builder#293
In order to make the tests work @ui5/builder#293 needs to be linked into the project.