Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Properties File Escaping #214

Merged
merged 10 commits into from
Jul 29, 2019
Merged

[FEATURE] Properties File Escaping #214

merged 10 commits into from
Jul 29, 2019

Commits on Jul 29, 2019

  1. [FEATURE] Properties File Escaping 

    serveResources uses stringEscaper to escape .properties files.
    @tobiasso85
    tobiasso85 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    695beb6 View commit details
    Browse the repository at this point in the history

  2. Adjust implementation according to latest changes in builder 

    Default is "ISO-8859-1"
    @tobiasso85
    tobiasso85 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    a5da8ef View commit details
    Browse the repository at this point in the history

  3. Switch to async await to simplify workflow

    @tobiasso85
    tobiasso85 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    c9167d8 View commit details
    Browse the repository at this point in the history

  4. adjust config structure change of propertiesFileEncoding in ui5.yml

    @tobiasso85
    tobiasso85 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    e32dabb View commit details
    Browse the repository at this point in the history

  5. Rename encoding property option 

    propertiesFileEncoding -> propertiesSourceFileEncoding
    @tobiasso85
    tobiasso85 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    9832dd3 View commit details
    Browse the repository at this point in the history

  6. Change property name for encoding 

    propertiesSourceFileEncoding -> propertiesFileSourceEncoding
    @tobiasso85
    tobiasso85 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    87a7474 View commit details
    Browse the repository at this point in the history

  7. serve resources now uses normal content-type independent from file type 

    No special logic for properties files regarding charset and type.
    @tobiasso85
    tobiasso85 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    12a47a0 View commit details
    Browse the repository at this point in the history

  8. fix tests

    @tobiasso85
    tobiasso85 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    cd6aea6 View commit details
    Browse the repository at this point in the history

  9. Restructure serveResources tests to simplify them 

    Fix test messages in main.js
    @tobiasso85
    tobiasso85 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    04f7f74 View commit details
    Browse the repository at this point in the history

  10. Add comment to serveResource test 

    The resource is drained because it is piped in the serveResources
middleware. Therefore the getStream and pipe functionality is stubbed.
Such that its content can be compared in the test.
    @tobiasso85
    tobiasso85 committed Jul 29, 2019
    Configuration menu
    Copy the full SHA
    62dd62f View commit details
    Browse the repository at this point in the history