Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add CSP middleware #3

Merged
merged 4 commits into from
Jul 6, 2018
Merged

[FEATURE] Add CSP middleware #3

merged 4 commits into from
Jul 6, 2018

Conversation

domianer
Copy link
Contributor

@domianer domianer commented Apr 4, 2018

Adds a Content Security Policy (CSP) middleware which can be enabled via URL parameter (sap-ui-xx-csp-policy). One can set the value to a policy string directly, or use one of the already defined policy IDs (sap-target-level-1, sap-target-level-2).

The OpenUI5 QUnit test "sap/ui/core/qunit/csp/ContentSecurityPolicy.qunit.html" can be used for a starting point validating for CSP compliance.

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2018

CLA assistant check
All committers have signed the CLA.

@domianer domianer added the enhancement New feature or request label Apr 4, 2018
@domianer domianer self-assigned this Apr 4, 2018
@matz3
Copy link
Member

matz3 commented Apr 6, 2018

@domianer the ESLint checks are failing. Could you please check? Just run npm test in your project to see the errors.

@codeworrior
Copy link
Member

codeworrior commented Jul 4, 2018

Policies should be updated to sap-target-level-1 and sap-target-level-2.

@codeworrior
Copy link
Member

ESLint issues have been fixed, tests have been added and the policies have been updated :-)

Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matz3 matz3 merged commit f9ec3ee into master Jul 6, 2018
@matz3 matz3 deleted the add-csp-middleware branch July 6, 2018 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants